Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Technical/issue 293 mocha refactor #294

Merged
merged 3 commits into from
Mar 2, 2020
Merged

Technical/issue 293 mocha refactor #294

merged 3 commits into from
Mar 2, 2020

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Feb 26, 2020 •
edited
Loading

Related Issue

resolves #293

Should be merged after #290

Summary of Changes

  1. Created a mocha configuration file and moved configuration from package.json to .mocharc.js
  2. Pre-included ..mocharc.js in .eslintignore for Chore/eslint config file javascript and lint #290
  3. Have test:tdd piggy back off of test, can confirm the --watch flag is forwarded 
    $ yarn test:tdd
yarn run v1.12.3
$ yarn test --watch
$ export BROWSERSLIST_IGNORE_OLD_DATA=true && yarn clean && nyc mocha --watch
$ rimraf ./**/.greenwood/** && rimraf ./**/public/** && rimraf ./coverage

@thescientist13 thescientist13 added the chore unit testing, maintenance, etc label Feb 26, 2020
thescientist13
thescientist13 commented Feb 26, 2020
View reviewed changes
.mocharc.js
const path = require('path');

module.exports = {
spec: path.join(__dirname, 'packages/**/test/**/**/**/*.spec.js'),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a file in packages/cli/test/unit/deeply/deeper/nested.spec.js and this configuration file picked everything up

@thescientist13 thescientist13 mentioned this pull request Feb 26, 2020
Merged
@thescientist13 thescientist13 force-pushed the technical/issue-293-mocha-refactor branch from df63514 to 8eb8375 Compare March 2, 2020 00:21
@thescientist13
Copy link
Member Author

GitHub Actions failed with this error on the NodeJS setup step itself.

Will try re-running the job.

@thescientist13
Copy link
Member Author

Merging per consensus reached during the last project meeting and no standing objections / comments on this PR.

@thescientist13 thescientist13 merged commit d35d0fe into master Mar 2, 2020
@thescientist13 thescientist13 deleted the technical/issue-293-mocha-refactor branch March 2, 2020 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hutchgrant hutchgrant Awaiting requested review from hutchgrant

@aholtzman aholtzman Awaiting requested review from aholtzman

Assignees
No one assigned
Labels
chore unit testing, maintenance, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reduce duplication in mocha testing configuration
1 participant
@thescientist13