Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/issue 777 restore init stdio terminal output #786

Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Nov 3, 2021

Related Issue

related to #777

Basically, with the change I made to use ignore you wouldn't see any install specific logs, so from a user's perspective, it would be hard to tell if something was happening or not until the whole script completed. At the time I thought this was causing a test failure for Yarn due to some warnings getting thrown as errors

  0 passing (3s)
  1 failing

  1) Scaffold Greenwood With Yarn: 
       default minimal template
         "before all" hook in "default minimal template":
     Error: the string "warning @greenwood/cli > markdown-toc > gray-matter > coffee-script@1.12.7: CoffeeScript on NPM has moved to \"coffeescript\" (no hyphen)\n" was thrown, throw an Error :)
      at processTicksAndRejections (node:internal/process/task_queues:93:5)

But tests still pass in this configuration (maybe it was due to me having debug output on with gallinago?), so happy to get the best of both worlds now. 🤞

Summary of Changes

  1. Revert init package to inherit stdio to show install logs

Ah well, it didn't work after all. So keeping stdio for now and making a follow up issue to track getting these to play nicely - #787

@thescientist13 thescientist13 added bug Something isn't working Init labels Nov 3, 2021
@thescientist13 thescientist13 added this to the 1.0 milestone Nov 3, 2021
@thescientist13
Copy link
Member Author

thescientist13 commented Nov 3, 2021

Hmm, looks like the Windows action failed on the initial yarn install for the action itself, so phew to that.

yarn install v1.22.17
[1/4] Resolving packages...
[2/4] Fetching packages...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
error An unexpected error occurred: "https://registry.yarnpkg.com/rxjs/-/rxjs-6.6.3.tgz: ESOCKETTIMEDOUT".
info If you think this is a bug, please open a bug report with the information provided in "D:\\a\\greenwood\\greenwood\\yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Error: Process completed with exit code 1.

Will rerun it in a few after i see how the other action goes, which so far seems to be passing every step so far. 😅

@thescientist13
Copy link
Member Author

Ah well, I almost got away with it too if it wasn't for you meddling CI checks. Looks like this does indeed cause a test failure after all

  1) Scaffold Greenwood and Run Build command: 
       default minimal template
         "before all" hook in "default minimal template":
     Error: the string "\n" was thrown, throw an Error :)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:95:5)

  2) Scaffold Greenwood and Run Develop command: 
       default minimal template
         "before all" hook in "default minimal template":
     Error: the string "\n" was thrown, throw an Error :)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:95:5)

  3) Scaffold Greenwood With Yarn: 
       default minimal template
         "before all" hook in "default minimal template":
     Error: the string "warning @greenwood/cli > cssnano > cssnano-preset-default > postcss-svgo > svgo@1.3.2: This SVGO version is no longer supported. Upgrade to v2.x.x.\n" was thrown, throw an Error :)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:95:5)

I will disable the Yarn test for now then and create another issue to track. So close. 😮‍💨

@thescientist13
Copy link
Member Author

Great, so they're all failing now? wtf.... 😭
https://github.com/ProjectEvergreen/greenwood/runs/4095931948?check_suite_focus=true

Have to disable them all? that's hella lame. 😡

@thescientist13 thescientist13 added the help wanted Extra attention is needed label Nov 3, 2021
@thescientist13 thescientist13 merged commit 839ad80 into master Nov 4, 2021
@thescientist13 thescientist13 deleted the bug/issue-777-restore-init-stdio-terminal-output branch November 4, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha.3 bug Something isn't working help wanted Extra attention is needed Init v0.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant