-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/issue 777 restore init stdio terminal output #786
Bug/issue 777 restore init stdio terminal output #786
Conversation
Hmm, looks like the Windows action failed on the initial yarn install v1.22.17
[1/4] Resolving packages...
[2/4] Fetching packages...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
error An unexpected error occurred: "https://registry.yarnpkg.com/rxjs/-/rxjs-6.6.3.tgz: ESOCKETTIMEDOUT".
info If you think this is a bug, please open a bug report with the information provided in "D:\\a\\greenwood\\greenwood\\yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Error: Process completed with exit code 1. Will rerun it in a few after i see how the other action goes, which so far seems to be passing every step so far. 😅 |
Ah well, I almost got away with it too if it wasn't for you meddling CI checks. Looks like this does indeed cause a test failure after all 1) Scaffold Greenwood and Run Build command:
default minimal template
"before all" hook in "default minimal template":
Error: the string "\n" was thrown, throw an Error :)
at runMicrotasks (<anonymous>)
at processTicksAndRejections (internal/process/task_queues.js:95:5)
2) Scaffold Greenwood and Run Develop command:
default minimal template
"before all" hook in "default minimal template":
Error: the string "\n" was thrown, throw an Error :)
at runMicrotasks (<anonymous>)
at processTicksAndRejections (internal/process/task_queues.js:95:5)
3) Scaffold Greenwood With Yarn:
default minimal template
"before all" hook in "default minimal template":
Error: the string "warning @greenwood/cli > cssnano > cssnano-preset-default > postcss-svgo > svgo@1.3.2: This SVGO version is no longer supported. Upgrade to v2.x.x.\n" was thrown, throw an Error :)
at runMicrotasks (<anonymous>)
at processTicksAndRejections (internal/process/task_queues.js:95:5) I will disable the Yarn test for now then and create another issue to track. So close. 😮💨 |
Great, so they're all failing now? wtf.... 😭 Have to disable them all? that's hella lame. 😡 |
Related Issue
related to #777
Basically, with the change I made to use
ignore
you wouldn't see anyinstall
specific logs, so from a user's perspective, it would be hard to tell if something was happening or not until the whole script completed. At the time I thought this was causing a test failure for Yarn due to some warnings getting thrown as errorsBut tests still pass in this configuration (maybe it was due to me having debug output on with gallinago?), so happy to get the best of both worlds now. 🤞
Summary of Changes
init
package toinherit
stdio to showinstall
logsAh well, it didn't work after all. So keeping
stdio
for now and making a follow up issue to track getting these to play nicely - #787