Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style updates per request in issue #17 #20

Merged
merged 1 commit into from
May 11, 2022

Conversation

aholtzman
Copy link
Member

NOTE: this PR covers the requested styling updates, though there were a11y issues seen - an audit & issue(s) should be done to address them.

Related Issue

checks one box on for issue #17 - styling change requested

Summary of Changes

  1. changed body display to flex from grid
  2. applied max-width & centering margin on main
  3. wrapped header content to maintain current alignment

@thescientist13 thescientist13 linked an issue May 8, 2022 that may be closed by this pull request
15 tasks
@thescientist13 thescientist13 mentioned this pull request May 8, 2022
15 tasks
Copy link
Member

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

It definitely just needed a little more room to breath, so this is great.

@@ -25,8 +31,6 @@ template.innerHTML = `
</main>

<wcc-footer></wcc-footer>

</main>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! 👀

@thescientist13 thescientist13 added the documentation Improvements or additions to documentation label May 8, 2022
@thescientist13 thescientist13 force-pushed the update/header-footer-spacing-styles branch from e621ad6 to 8e51ea6 Compare May 11, 2022 01:21
@thescientist13 thescientist13 merged commit 9f12d4c into master May 11, 2022
@thescientist13 thescientist13 deleted the update/header-footer-spacing-styles branch May 11, 2022 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go Live checklist
2 participants