Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/fix metadata spec name #21

Merged
merged 10 commits into from
May 11, 2022
Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented May 8, 2022

Related Issue

N / A

Summary of Changes

  1. realized spec had incorrect name

TODO

  1. make an issue to better handle this global state that was causing so many issues 😮‍💨 - refactor custom element definitions being shared #24

@thescientist13 thescientist13 reopened this May 8, 2022
@thescientist13
Copy link
Member Author

thescientist13 commented May 8, 2022

Hmm, this doesn't fail locally? 🤔

@thescientist13 thescientist13 self-assigned this May 8, 2022
@thescientist13
Copy link
Member Author

thescientist13 commented May 10, 2022

Hmm, so when debugging in the PR run, it looks like components from other specs are coming through?

{
  metadata: [
    'wcc-counter': { instanceName: 'Counter', moduleURL: [URL] },
    'wcc-paragraph': { instanceName: 'MyParagraph', moduleURL: [URL] },
    'wcc-footer': { instanceName: 'Footer', moduleURL: [URL], hydrate: 'lazy' },
    'wcc-header': { instanceName: 'Header', moduleURL: [URL] },
    'wcc-navigation': { instanceName: 'Navigation', moduleURL: [URL] }
  ]
}
the keyyyyyssss!!!! [
  'wcc-counter',
  'wcc-paragraph',
  'wcc-footer',
  'wcc-header',
  'wcc-navigation'
]

my-paragraph comes from the children-and-slot spec. 😵


So I guess because of how we're declaring const deps in wcc.js and perhaps the way mocha handles loading all tests

this may be behavior to work around? Not that I am opposed to refactoring it, but wonder why it only breaks for GitHub Actions?

@netlify
Copy link

netlify bot commented May 10, 2022

Deploy Preview for merry-caramel-524e61 failed.

Name Link
🔨 Latest commit 01f3c0f
🔍 Latest deploy log https://app.netlify.com/sites/merry-caramel-524e61/deploys/6279b899bc63af00086e23cf

@thescientist13 thescientist13 merged commit 5a4e9af into master May 11, 2022
@thescientist13 thescientist13 deleted the chore/fix-metadata-spec-name branch May 11, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant