Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate lightMode config and update website and docs accordingly #61

Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jun 10, 2022

Related Issue

resolves #52

Summary of Changes

  1. Refactor website to use innerHTML
  2. Update compiler to drop support for lightMode configuration and remove from build.js
  3. Update documentation to remove reference to lightMode

TODO

  1. Not sure if this implicates this getInnerHTML issue at all?
  2. Open up a discussion to capture the original intent / use case, just for posterity in case its something worth re-investigating - just included with verify / ensure proper serialization of shadow roots excluding closed shadow roots from getInnerHTML #16

@thescientist13 thescientist13 force-pushed the deprecation/issue-52-light-mode-configuration branch from 628f4ee to 16653fa Compare June 10, 2022 12:19
@thescientist13 thescientist13 merged commit d94281a into master Jun 10, 2022
@thescientist13 thescientist13 deleted the deprecation/issue-52-light-mode-configuration branch June 10, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate lightMode configuration option
1 participant