fix HTMLTemplateElement
implementation to reflect standards behavior
#63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #51
Summary of Changes
<template>
tag logic insideHTMLTemplateElement
<template>
implementation<template>
implementationTODO
Make sure- support configurablethis.mode
works fromattachShadow
shadowroot
attribute for<template>
tags #65Questions
getInnerHTML
to make sure things are / will be still compatible -verify / ensure proper serialization of shadow roots excluding closed shadow roots fromgetInnerHTML
#16get innerHTML
forHTMLTemplateElement
? - tracked in `<template>` tags with variable interpolation for Declarative Shadow DOM #66<templates>
but with variables / template literal placeholders. Or just create render functions?.... But then you lose the free<template>
tag from usingdocument.createElement('template')
. Maybe create some experimentalset
function fortemplate.innerHTML = '....'
that can take args and destructure them? - `<template>` tags with variable interpolation for Declarative Shadow DOM #66