Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle undefined custom elements with console.warn message #78

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Gracefully handle undefined custom elements with console.warn message #78

merged 1 commit into from
Jul 21, 2022

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jul 18, 2022 •
edited
Loading

Related Issue

resolves #25

Summary of Changes

  1. If a customElement has not been defined, just show a warning message instead of failing outright

WARNING: customElement <xxx-yyyyy> is not defined. You may not have imported it yet.

@thescientist13 thescientist13 added the enhancement Improvement to existing functionality label Jul 18, 2022
@thescientist13 thescientist13 changed the title show console.warn instead if custom element is rendered without already being defined Gracefully handle undefined custom elements with console.warn message Jul 18, 2022
@thescientist13 thescientist13 mentioned this pull request Jul 18, 2022
Closed
@thescientist13 thescientist13 force-pushed the enhancement/issue-25-gracefully-handle-unregistered-custom-element branch from 1139a82 to b8e70da Compare July 21, 2022 14:34
@thescientist13 thescientist13 merged commit 6de8465 into master Jul 21, 2022
@thescientist13 thescientist13 deleted the enhancement/issue-25-gracefully-handle-unregistered-custom-element branch July 21, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

handle usage of unregistered custom elements
1 participant
@thescientist13