Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Friend&Ignore List #4

Closed
Light2 opened this issue Jul 9, 2013 · 0 comments
Closed

Friend&Ignore List #4

Light2 opened this issue Jul 9, 2013 · 0 comments
Labels
Feature
Milestone
0.1

Comments

@Light2
Copy link
Contributor

Light2 commented Jul 9, 2013

No description provided.

@Levarrishawk Levarrishawk mentioned this issue Dec 5, 2013
Open
Treeku added a commit that referenced this issue Mar 29, 2014
@Treeku
Player flag is set when you align to a faction ->
73bef32 
When you join a faction, #16 is set to true.

When you go combatant, #32 is set to true.  The resulting flag: 48

When you go SF, #1, #2 and #4 are set to true.  The resulting flag: 55

When you go back to combatant, #1, #2 and #4 are set to false.  The resulting flag: 48

The error was either in the Player flag not being set anywhere, or setPvpStatus setting it instead of doing OR/XOR operations.

(The result of this would be bit #16 wouldn't be set to true, meaning SF would be 39 instead of 55)

We could still set all of the flags to true for SF without harm for safety, it just wasn't theoretically necessary.

Additionally any players that login automatically were getting #16 sent to the client by sendBaselines() regardless of if they had a faction, which should now be fixed.
Treeku added a commit that referenced this issue Mar 29, 2014
@Treeku
calculatePvpStatus() used for everything, more...
9ff6698 
This ensures nothing is ever missed out of the pvpStatus calculation,
such as faction standing.  It should calculate the following:

On Leave/neutral players should be #16

Combatant players should be #35

Opposing faction SF players should be #55

Opposing Combatant NPCs should be #19

Ally SF NPCs (ie.; hoth commandos) should be #4

Enemy SF NPCs (ie. hoth resistance) should be #7

Same faction NPCs should be #0 (pink)

Attackable NPCs should be #1

Aggressive NPCs should be #2 or #3

NPCs you have negative faction standing with should be #2 or #3
Undercova added a commit that referenced this issue Apr 24, 2014
@Undercova
Merge pull request #4 from ProjectSWGCore/master
52de32f 
Update my branch
@ghost ghost mentioned this issue Apr 27, 2014
Closed
@Undercova Undercova reopened this May 2, 2014
Treeku pushed a commit that referenced this issue May 19, 2014
@tacef
Merge pull request #4 from ProjectSWGCore/master
1b03c4e 
Update local fork
Treeku pushed a commit that referenced this issue Jun 4, 2014
Merge pull request #4 from ProjectSWGCore/master
17e7964 
pull
CharonInferar pushed a commit that referenced this issue Jun 25, 2014
Merge pull request #4 from ProjectSWGCore/master
20fd6e9 
pull
ghost pushed a commit that referenced this issue Aug 13, 2014
Merge pull request #4 from ProjectSWGCore/master
e8b5744 
pull
ghost pushed a commit that referenced this issue Sep 2, 2014
Merge pull request #4 from ProjectSWGCore/master
837723a 
pull
Skorpios0 pushed a commit that referenced this issue Nov 9, 2014
@Mesagoppinmypants
Merge pull request #4 from ProjectSWGCore/master
b80a749 
Update fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
0.1
Development

No branches or pull requests
3 participants
@lewismorgan @Light2 @Undercova