Modal anchors #76
Merged
Modal anchors #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgleason
requested changes
Nov 5, 2018
| @@ -165,4 +165,5 @@ <h3>{{course.university }}</h3> | |||
|
|
|||
| {% block extra_js %} | |||
| <script src="{% static "js/filters.js" %}"></script> | |||
| <script src="{% static "js/modals.js" %}">></script> | |||
There was a problem hiding this comment.
You've got an extra > there.
project_tier/static/js/modals.js
Outdated
| function openModal(){ | ||
| var location = window.location.hash.substring(6); | ||
| var modal = "course-" + location + "-modal"; | ||
| $("#" + modal).foundation("open"); |
There was a problem hiding this comment.
Doesn't this error out when the page loads with no hash (or an invalid one)?
|
This should be ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a little bit of weirdness here where, ironically, if you go directly to the modal, although it opens and displays properly, it actually clears the hash from the URL. This is because I had to scroll to the top of the page or else the modal was out of view on load. This shouldn't really be an issue for the use case we were trying to address here.
Otherwise, if you click a card it will display the proper URL in the browser and allow users to easily share course material links.