-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move song doesn't work #280
Comments
Somehow I came to the conclusion the stationToken worked, see |
The trackToken is still rather opaque to me, but there are definitely patterns to be noticed. The length is either 96 or 112 characters. |
Doesn’t work with JSON API. See #280.
I removed the move song feature. Perhaps “create station from song” is Moving back to XMLRPC is not an option and I doubt we can reliably |
The song move feature and its corresponding eventcmd, songmove, got removed in 845cf4c (see PromyLOPh#280). This removes the final vestiges of that feature by cleaning up the documentation that still referenced it.
Note: I'm inclined to believe that the problem is on Pandora's end, but I'm opening the issue here to see if there's any other ideas.
Using 'm' to move a track to another station does not achieve the desired result. The expected outcome is that the track is given thumbs-down on the current station, and thumbs-up on the destination station.
What actually happens is that 'm' simply gives a thumbs-up to the track on the current station.
I've looked into the behavior and as currently implemented, pianobar uses the JSON v5 API method station.addFeedback. What I've observed is that the stationToken is ignored, and that the trackToken seems to have sufficient information for the feedback to be registered on the server. As a consequence, the thumbs-up will cancel out the thumbs-down given on the same station.
If the implementation is changed such that the order of the thumbs-up and thumbs-down is reversed, the thumbs-down will cancel out the thumbs-up on the current station, but the destination station will be unaffected.
It's been rather frustrating to figure out how this really ought to work, since I don't have a working example of the correct approach anywhere. The Pandora web-based client still uses the XMLRPC v34 API, which appears to respect the station token, but it provides no insight with regard to the JSON interface. The Pandora One desktop client doesn't even implement the "move song" capability, and I don't know if any of the mobile clients have it either.
On a couple of occasions I have been able to modify the track token by copying and pasting chunks of the hex string from one track to another to get the thumbs-up to take effect on a different station, but it's very hit-or-miss and I still haven't figured out a logical mapping from stations to some substring of the track token. Most of the time I get "invalid station" or "internal error" instead.
A possible workaround would be to fallback to using XMLRPC for this particular action, but I'd imagine that's a pretty ugly hack that might break again in short order, so it's probably too much effort for too little gain.
The text was updated successfully, but these errors were encountered: