Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parsing and serializing interfaces for keyrings #275

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Add parsing and serializing interfaces for keyrings #275

merged 2 commits into from
Apr 8, 2024

Conversation

wussler
Copy link
Collaborator

@wussler wussler commented Apr 4, 2024

This PR adds an API to serialize KeyRings to binary data:

func (keyRing *KeyRing) Serialize() ([]byte, error)

and an API to parse KeyRings from binary data:

func NewKeyRingFromBinary(binKeys []byte) (*KeyRing, error)

lubux
lubux approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@lubux lubux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crypto/keyring.go Outdated Show resolved Hide resolved
@wussler wussler merged commit 0d1ce13 into main Apr 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubux lubux lubux approved these changes

@twiss twiss twiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wussler @twiss @lubux