Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya,
I saw someone over on Reddit asking why Protonmail doesn't support
mailto:
style links. I'd been looking to mess around with the iOS codebase and had some free time, so experimented with adding it.From what I read on another issue you've got a refactor going on internally, so no worries if this doesn't fit right now - just wanted to throw it out there and open discussion on it. The reason something like this would be nice is that if it's supported, then Firefox on iOS could open
mailto:
links in Protonmail if the user chooses it in settings.I made the requisite changes in Firefox iOS already, could pull request them over there if/when this is deemed okay over here.
Not 100% happy about the
Dispatch
delay hack but I didn't want to muck too much with altering the internal structure. Open to comments/critiques/etc for sure.A simple test project can be drummed up by making a blank iOS project in Xcode, whitelisting
LSApplicationQueriesSchemes
to includeprotonmail
, and then dumping something like the following inapplicationDidFinishLaunching
:Hope it's useful!