[WIP] Introducing OpenPGPjs v5 #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into openpgpjs-v5
…into openpgpjs-v5
twiss
reviewed
Oct 9, 2020
| @@ -1,4 +1,14 @@ | |||
| import { openpgp } from './openpgp'; | |||
| import { unarmor, stream } from 'openpgp'; | |||
There was a problem hiding this comment.
Could you import stream from web-stream-tools (same as openpgp is doing) instead of from openpgp? (And only import the functions you need)
Comment on lines
+8
to
+11
| export const isStream = (args) => stream.isStream(args); | ||
| export const concatArrays = (args) => stream.concatUint8Array(args); | ||
| export const readToEnd = (args) => stream.readToEnd(args); | ||
| export const transform = (args) => stream.transform(args); |
There was a problem hiding this comment.
I know the original code was also doing this, but this can be shortened to
export const isStream = stream.isStream;or even:
export { isStream, ... } from 'web-stream-tools';
twiss
reviewed
Oct 12, 2020
|
Superseeded by #123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.