-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google calendar support #93
Conversation
This is a great idea! I noticed a few problems though: The thing is too wide and causes horizontal scrolling on mobile: And it's not intuitive that you need to click the button after selecting it from the dropdown. That's not a big deal though. I suspect all that's needed is a vertical line left of the arrow. |
Oup, didn't mean to close lol |
I also noticed a bug when Google Calendar or Download ICS is my saved option, I refresh the page, I open the dropdown, then click outside the dropdown. The setting is changed back to Email but it only happens the first time after a refresh. |
Fixed the issues in those commits. I tried to break the commits up so you can follow the changes easier. Note: you'll have to delete the key from your browser's localStorage or it will crash since I capitalized the value. Also you can use |
Can you test my changes? Then I'll merge + deploy |
Nice! Looks good, thanks for fixing it up. Good call changing the button text to the short form. I think it strikes a better balance between explaining what the button does and keeping it a good size when the dropdown in collapsed I'm having a hard time figuring out what |
Disabling |
For whatever reason, I have a hell of a time adding classes to my calendar on my iPhone. I can't figure out how to get
ics
files to open in google calendar so I did this instead:Screencast.from.07-10-2022.12.18.03.PM.webm
localStorage
. Whatever the user selects as their option will persist across page reloads.Let me know if you detect any bugs or weirdness. Happy to fix