Implement additional features to the "group" element type #2394

collinc97 · 2023-05-24T22:48:34Z

Changes implemented to be compatible with https://github.com/AleoHQ/snarkVM/pull/1576

Motivation

This PR introduces new commit_to_group, hash_many (placeholder), hash_to_group, and hash_to_scalar opcodes.

partially addresses #2386

Changelog

As part of this PR, all hash.* and commit.* opcodes now return a field type as the default, and we introduce commit_to_group, hash_to_group, and hash_to_scalar for other return types (that are cryptographically safe).

The existing opcodes commit.ped64 and commit.ped128 have had their return type changed from group to field, to adhere to the updated design.

Aleo instructions commit opcodes

commit_to_group.bhp256
commit_to_group.bhp512
commit_to_group.bhp768
commit_to_group.bhp1024
commit_to_group.ped64
commit_to_group.ped128

Leo commit methods

let a: group = BHP256::commit_to_group(ANY, SCALAR);
let a: group = BHP512::commit_to_group(ANY, SCALAR);
let a: group = BHP768::commit_to_group(ANY, SCALAR);
let a: group = BHP1024::commit_to_group(ANY, SCALAR);
let a: group = Pedersen64::commit_to_group(ANY, SCALAR);
let a: group = Pedersen128::commit_to_group(ANY, SCALAR);

Aleo instructions hash opcodes

hash_to_group.bhp256
hash_to_group.bhp512
hash_to_group.bhp768
hash_to_group.bhp1024
hash_to_group.ped64
hash_to_group.ped128
hash_to_group.psd2
hash_to_group.psd4
hash_to_group.psd8
hash_to_scalar.psd2
hash_to_scalar.psd4
hash_to_scalar.psd8

Leo hash methods

let a: group = BHP256::hash_to_group(ANY);
let a: group = BHP512::hash_to_group(ANY);
let a: group = BHP768::hash_to_group(ANY);
let a: group = BHP1024::hash_to_group(ANY);
let a: group = Pedersen64::hash_to_group(ANY);
let a: group = Pedersen128::hash_to_group(ANY);
let a: group = Poseidon2::hash_to_group(ANY);
let a: group = Poseidon4::hash_to_group(ANY);
let a: group = Poseidon8::hash_to_group(ANY);
let a: scalar = Poseidon2::hash_to_scalar(ANY);
let a: scalar = Poseidon4::hash_to_scalar(ANY);
let a: scalar = Poseidon8::hash_to_scalar(ANY);

codecov · 2023-05-25T01:02:40Z

Codecov Report

Merging #2394 (e390194) into testnet3 (ae12c35) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           testnet3    #2394      +/-   ##
============================================
+ Coverage     78.57%   78.65%   +0.07%     
============================================
  Files           154      154              
  Lines          4691     4708      +17     
  Branches       4690     4707      +17     
============================================
+ Hits           3686     3703      +17     
  Misses         1005     1005

Impacted Files	Coverage Δ
compiler/ast/src/functions/core_function.rs	`100.00% <ø> (ø)`
compiler/span/src/symbol.rs	`84.61% <ø> (ø)`
compiler/compiler/tests/execute.rs	`86.88% <100.00%> (+0.21%)`	⬆️
compiler/passes/src/type_checking/checker.rs	`95.83% <100.00%> (-0.25%)`	⬇️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

bendyarm · 2023-06-07T05:55:43Z

tests/tests/compiler/core/algorithms/bhp1024_hash_to_group.leo

+        let scalar_value: scalar = 1scalar;
+        // let string_value: string = "helloworld";
+
+        // BHP256 hash_to_group tests


It looks like these should be BHP1024

bendyarm · 2023-06-07T05:57:09Z

tests/tests/compiler/core/algorithms/bhp512_hash_to_group.leo

+        let scalar_value: scalar = 1scalar;
+        // let string_value: string = "helloworld";
+
+        // BHP256 hash_to_group tests


It looks like these should be BHP512

tests/tests/compiler/core/algorithms/bhp768_hash_to_group.leo

bendyarm

There were 3 BHP test files that look like they need some find/replace attention. (Added direct comments on them already.)

d0cd

LGTM!

bendyarm · 2023-06-07T18:00:33Z

tests/tests/compiler/core/algorithms/bhp512_hash_to_group.leo

+        // BHP256 hash_to_group tests
+        let a: group = BHP256::hash_to_group(addr_value);
+        let b: group = BHP256::hash_to_group(bool_value);
+        let c: group = BHP256::hash_to_group(field_value);
+        // let d: group = BHP256::hash_to_group(group_value);
+        let e: group = BHP256::hash_to_group(i8_value);
+        let f: group = BHP256::hash_to_group(i16_value);
+        let g: group = BHP256::hash_to_group(i32_value);
+        let h: group = BHP256::hash_to_group(i64_value);
+        let i: group = BHP256::hash_to_group(i128_value);
+        let j: group = BHP256::hash_to_group(u8_value);
+        let k: group = BHP256::hash_to_group(u16_value);
+        let l: group = BHP256::hash_to_group(u32_value);
+        let m: group = BHP256::hash_to_group(u64_value);
+        let n: group = BHP256::hash_to_group(u128_value);
+        let o: group = BHP256::hash_to_group(scalar_value);
+        // let p: group = BHP256::hash_to_group(string_value);
+        let q: group = BHP256::hash_to_group(Foo { a: 1u128, b: 1u128 });


Suggested change

// BHP256 hash_to_group tests

let a: group = BHP256::hash_to_group(addr_value);

let b: group = BHP256::hash_to_group(bool_value);

let c: group = BHP256::hash_to_group(field_value);

// let d: group = BHP256::hash_to_group(group_value);

let e: group = BHP256::hash_to_group(i8_value);

let f: group = BHP256::hash_to_group(i16_value);

let g: group = BHP256::hash_to_group(i32_value);

let h: group = BHP256::hash_to_group(i64_value);

let i: group = BHP256::hash_to_group(i128_value);

let j: group = BHP256::hash_to_group(u8_value);

let k: group = BHP256::hash_to_group(u16_value);

let l: group = BHP256::hash_to_group(u32_value);

let m: group = BHP256::hash_to_group(u64_value);

let n: group = BHP256::hash_to_group(u128_value);

let o: group = BHP256::hash_to_group(scalar_value);

// let p: group = BHP256::hash_to_group(string_value);

let q: group = BHP256::hash_to_group(Foo { a: 1u128, b: 1u128 });

// BHP512 hash_to_group tests

let a: group = BHP512::hash_to_group(addr_value);

let b: group = BHP512::hash_to_group(bool_value);

let c: group = BHP512::hash_to_group(field_value);

// let d: group = BHP512::hash_to_group(group_value);

let e: group = BHP512::hash_to_group(i8_value);

let f: group = BHP512::hash_to_group(i16_value);

let g: group = BHP512::hash_to_group(i32_value);

let h: group = BHP512::hash_to_group(i64_value);

let i: group = BHP512::hash_to_group(i128_value);

let j: group = BHP512::hash_to_group(u8_value);

let k: group = BHP512::hash_to_group(u16_value);

let l: group = BHP512::hash_to_group(u32_value);

let m: group = BHP512::hash_to_group(u64_value);

let n: group = BHP512::hash_to_group(u128_value);

let o: group = BHP512::hash_to_group(scalar_value);

// let p: group = BHP512::hash_to_group(string_value);

let q: group = BHP512::hash_to_group(Foo { a: 1u128, b: 1u128 });

bendyarm · 2023-06-07T18:06:36Z

tests/tests/compiler/core/algorithms/bhp1024_hash_to_group.leo

+        // BHP256 hash_to_group tests
+        let a: group = BHP256::hash_to_group(addr_value);
+        let b: group = BHP256::hash_to_group(bool_value);
+        let c: group = BHP256::hash_to_group(field_value);
+        // let d: group = BHP256::hash_to_group(group_value);
+        let e: group = BHP256::hash_to_group(i8_value);
+        let f: group = BHP256::hash_to_group(i16_value);
+        let g: group = BHP256::hash_to_group(i32_value);
+        let h: group = BHP256::hash_to_group(i64_value);
+        let i: group = BHP256::hash_to_group(i128_value);
+        let j: group = BHP256::hash_to_group(u8_value);
+        let k: group = BHP256::hash_to_group(u16_value);
+        let l: group = BHP256::hash_to_group(u32_value);
+        let m: group = BHP256::hash_to_group(u64_value);
+        let n: group = BHP256::hash_to_group(u128_value);
+        let o: group = BHP256::hash_to_group(scalar_value);
+        // let p: group = BHP256::hash_to_group(string_value);
+        let q: group = BHP256::hash_to_group(Foo { a: 1u128, b: 1u128 });


Suggested change

// BHP256 hash_to_group tests

let a: group = BHP256::hash_to_group(addr_value);

let b: group = BHP256::hash_to_group(bool_value);

let c: group = BHP256::hash_to_group(field_value);

// let d: group = BHP256::hash_to_group(group_value);

let e: group = BHP256::hash_to_group(i8_value);

let f: group = BHP256::hash_to_group(i16_value);

let g: group = BHP256::hash_to_group(i32_value);

let h: group = BHP256::hash_to_group(i64_value);

let i: group = BHP256::hash_to_group(i128_value);

let j: group = BHP256::hash_to_group(u8_value);

let k: group = BHP256::hash_to_group(u16_value);

let l: group = BHP256::hash_to_group(u32_value);

let m: group = BHP256::hash_to_group(u64_value);

let n: group = BHP256::hash_to_group(u128_value);

let o: group = BHP256::hash_to_group(scalar_value);

// let p: group = BHP256::hash_to_group(string_value);

let q: group = BHP256::hash_to_group(Foo { a: 1u128, b: 1u128 });

// BHP1024 hash_to_group tests

let a: group = BHP1024::hash_to_group(addr_value);

let b: group = BHP1024::hash_to_group(bool_value);

let c: group = BHP1024::hash_to_group(field_value);

// let d: group = BHP1024::hash_to_group(group_value);

let e: group = BHP1024::hash_to_group(i8_value);

let f: group = BHP1024::hash_to_group(i16_value);

let g: group = BHP1024::hash_to_group(i32_value);

let h: group = BHP1024::hash_to_group(i64_value);

let i: group = BHP1024::hash_to_group(i128_value);

let j: group = BHP1024::hash_to_group(u8_value);

let k: group = BHP1024::hash_to_group(u16_value);

let l: group = BHP1024::hash_to_group(u32_value);

let m: group = BHP1024::hash_to_group(u64_value);

let n: group = BHP1024::hash_to_group(u128_value);

let o: group = BHP1024::hash_to_group(scalar_value);

// let p: group = BHP1024::hash_to_group(string_value);

let q: group = BHP1024::hash_to_group(Foo { a: 1u128, b: 1u128 });

bendyarm · 2023-06-07T18:12:01Z

tests/tests/compiler/core/algorithms/bhp768_hash_to_group.leo

+        // BHP256 hash_to_group tests
+        let a: group = BHP256::hash_to_group(addr_value);
+        let b: group = BHP256::hash_to_group(bool_value);
+        let c: group = BHP256::hash_to_group(field_value);
+        // let d: group = BHP256::hash_to_group(group_value);
+        let e: group = BHP256::hash_to_group(i8_value);
+        let f: group = BHP256::hash_to_group(i16_value);
+        let g: group = BHP256::hash_to_group(i32_value);
+        let h: group = BHP256::hash_to_group(i64_value);
+        let i: group = BHP256::hash_to_group(i128_value);
+        let j: group = BHP256::hash_to_group(u8_value);
+        let k: group = BHP256::hash_to_group(u16_value);
+        let l: group = BHP256::hash_to_group(u32_value);
+        let m: group = BHP256::hash_to_group(u64_value);
+        let n: group = BHP256::hash_to_group(u128_value);
+        let o: group = BHP256::hash_to_group(scalar_value);
+        // let p: group = BHP256::hash_to_group(string_value);
+        let q: group = BHP256::hash_to_group(Foo { a: 1u128, b: 1u128 });


Suggested change

// BHP256 hash_to_group tests

let a: group = BHP256::hash_to_group(addr_value);

let b: group = BHP256::hash_to_group(bool_value);

let c: group = BHP256::hash_to_group(field_value);

// let d: group = BHP256::hash_to_group(group_value);

let e: group = BHP256::hash_to_group(i8_value);

let f: group = BHP256::hash_to_group(i16_value);

let g: group = BHP256::hash_to_group(i32_value);

let h: group = BHP256::hash_to_group(i64_value);

let i: group = BHP256::hash_to_group(i128_value);

let j: group = BHP256::hash_to_group(u8_value);

let k: group = BHP256::hash_to_group(u16_value);

let l: group = BHP256::hash_to_group(u32_value);

let m: group = BHP256::hash_to_group(u64_value);

let n: group = BHP256::hash_to_group(u128_value);

let o: group = BHP256::hash_to_group(scalar_value);

// let p: group = BHP256::hash_to_group(string_value);

let q: group = BHP256::hash_to_group(Foo { a: 1u128, b: 1u128 });

// BHP768 hash_to_group tests

let a: group = BHP768::hash_to_group(addr_value);

let b: group = BHP768::hash_to_group(bool_value);

let c: group = BHP768::hash_to_group(field_value);

// let d: group = BHP768::hash_to_group(group_value);

let e: group = BHP768::hash_to_group(i8_value);

let f: group = BHP768::hash_to_group(i16_value);

let g: group = BHP768::hash_to_group(i32_value);

let h: group = BHP768::hash_to_group(i64_value);

let i: group = BHP768::hash_to_group(i128_value);

let j: group = BHP768::hash_to_group(u8_value);

let k: group = BHP768::hash_to_group(u16_value);

let l: group = BHP768::hash_to_group(u32_value);

let m: group = BHP768::hash_to_group(u64_value);

let n: group = BHP768::hash_to_group(u128_value);

let o: group = BHP768::hash_to_group(scalar_value);

// let p: group = BHP768::hash_to_group(string_value);

let q: group = BHP768::hash_to_group(Foo { a: 1u128, b: 1u128 });

bendyarm

Added ```suggestion comments.

bendyarm

Looks good.

collinc97 added 8 commits May 24, 2023 11:53

add new hash and commit symbols

13834ec

pedersen commitment methods return fields

6b6b492

use snarkvm rev a451d91, impl commit_to_group.bhp256

2c3b9e4

implement bhp commit to group variants

74cd540

implement bhp hash_to_group variants

3e8f86d

implement pedersen commit_to_group and hash_to_scalar variants

319bfcc

implement poseidon hash_to_group and hash_to_scalar variants

3efbabf

remove hash_many symbol

20d90aa

collinc97 changed the title ~~Staging updates DRAFT~~ Implement additional features to the "group" element type May 25, 2023

merge testnet3 and set snarkvm rev to f69dc53

d3409b1

collinc97 marked this pull request as ready for review June 6, 2023 19:01

collinc97 requested review from d0cd, acoglio and bendyarm June 6, 2023 22:36

acoglio approved these changes Jun 6, 2023

View reviewed changes

bendyarm reviewed Jun 7, 2023

View reviewed changes

tests/tests/compiler/core/algorithms/bhp768_hash_to_group.leo Outdated Show resolved Hide resolved

bendyarm requested changes Jun 7, 2023

View reviewed changes

d0cd approved these changes Jun 7, 2023

View reviewed changes

fix tests

563f56e

bendyarm reviewed Jun 7, 2023

View reviewed changes

bendyarm requested changes Jun 7, 2023

View reviewed changes

bendyarm self-requested a review June 7, 2023 18:18

bendyarm approved these changes Jun 7, 2023

View reviewed changes

regen test expectations

e390194

collinc97 merged commit 4e71f60 into testnet3 Jun 7, 2023

collinc97 deleted the staging branch June 7, 2023 20:09

collinc97 mentioned this pull request Jun 7, 2023

Add new Leo group element syntax to operators table ProvableHQ/welcome#198

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement additional features to the "group" element type #2394

Implement additional features to the "group" element type #2394

collinc97 commented May 24, 2023 •

edited

Loading

codecov bot commented May 25, 2023 •

edited

Loading

bendyarm Jun 7, 2023

bendyarm Jun 7, 2023

bendyarm left a comment •

edited

Loading

d0cd left a comment

bendyarm Jun 7, 2023

bendyarm Jun 7, 2023

bendyarm Jun 7, 2023 •

edited

Loading

bendyarm left a comment

bendyarm left a comment

Implement additional features to the "group" element type #2394

Implement additional features to the "group" element type #2394

Conversation

collinc97 commented May 24, 2023 • edited Loading

Motivation

Changelog

Aleo instructions commit opcodes

Leo commit methods

Aleo instructions hash opcodes

Leo hash methods

codecov bot commented May 25, 2023 • edited Loading

Codecov Report

bendyarm Jun 7, 2023

Choose a reason for hiding this comment

bendyarm Jun 7, 2023

Choose a reason for hiding this comment

bendyarm left a comment • edited Loading

Choose a reason for hiding this comment

d0cd left a comment

Choose a reason for hiding this comment

bendyarm Jun 7, 2023

Choose a reason for hiding this comment

bendyarm Jun 7, 2023

Choose a reason for hiding this comment

bendyarm Jun 7, 2023 • edited Loading

Choose a reason for hiding this comment

bendyarm left a comment

Choose a reason for hiding this comment

bendyarm left a comment

Choose a reason for hiding this comment

collinc97 commented May 24, 2023 •

edited

Loading

codecov bot commented May 25, 2023 •

edited

Loading

bendyarm left a comment •

edited

Loading

bendyarm Jun 7, 2023 •

edited

Loading