Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement group::GEN Leo syntax #2401

Merged
merged 3 commits into from
May 31, 2023
Merged

implement group::GEN Leo syntax #2401

merged 3 commits into from
May 31, 2023

Conversation

collinc97
Copy link
Collaborator

@collinc97 collinc97 commented May 31, 2023

let g: group = group::GEN;
  • Implemented core constants to live in AST (compiler/ast/src/types/core_constant.rs)
  • Leo parser supports GEN symbol
  • Leo AST supports associated constants
  • Leo type checker emits group type
  • Leo code gen pass emits group::GEN operand compatible with latest AVM operand.
  • tests added, expectations updated
  • examples/groups/ program updated

@collinc97 collinc97 requested a review from d0cd May 31, 2023 19:00
@collinc97
Copy link
Collaborator Author

This PR partially addresses #2386

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #2401 (45ffd62) into testnet3 (369db97) will increase coverage by 0.24%.
The diff coverage is 93.75%.

@@             Coverage Diff              @@
##           testnet3    #2401      +/-   ##
============================================
+ Coverage     78.26%   78.50%   +0.24%     
============================================
  Files           152      153       +1     
  Lines          4615     4630      +15     
  Branches       4614     4629      +15     
============================================
+ Hits           3612     3635      +23     
+ Misses         1003      995       -8     
Impacted Files Coverage Δ
compiler/span/src/symbol.rs 80.76% <ø> (ø)
...iler/passes/src/type_checking/check_expressions.rs 81.78% <80.00%> (-0.04%) ⬇️
compiler/ast/src/types/core_constant.rs 100.00% <100.00%> (ø)
...er/passes/src/code_generation/visit_expressions.rs 82.25% <100.00%> (+0.95%) ⬆️
compiler/passes/src/type_checking/checker.rs 94.52% <100.00%> (+0.11%) ⬆️
...rors/src/errors/type_checker/type_checker_error.rs 79.38% <100.00%> (+0.88%) ⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@d0cd d0cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@collinc97 collinc97 marked this pull request as ready for review May 31, 2023 22:07
@collinc97 collinc97 merged commit 42d97d3 into testnet3 May 31, 2023
@collinc97 collinc97 deleted the feat/group-gen branch May 31, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants