Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip season from search if searching for season 1 on nyaa.si #420

Closed
1 task done
Atakku opened this issue Mar 19, 2024 · 5 comments
Closed
1 task done

Strip season from search if searching for season 1 on nyaa.si #420

Atakku opened this issue Mar 19, 2024 · 5 comments

Comments

@Atakku
Copy link

Atakku commented Mar 19, 2024

Is there an existing issue for this?

  • I have searched the existing open and closed issues

Is your feature request related to a problem? Please describe

My setup picks up the bottom torrent, but not the top, because the first one doesn't have a season number specified, therefore gets filtered on nyaa.si's side when prowlarr queries "Wonder Egg Priority S01"
(Without S01)
image
(With S01)
image

I think it would be nice to have this as an option, because i noticed that prowlarr never finds a lot of releases for single season anime's on nyaa.si, because those usually dont even have a season number in the title. The Sonarr compatibility helps sometimes, but can't help here as when you search S01 these results are filtered on nyaa.si side.

Describe the solution you'd like

An option to strip S01, Season 1, S1 and etc from the search requests for nyaa.si

Describe alternatives you've considered

Sonarr compatibility adds S01 to the missing release when I search for "Wonder Egg Priority" myself, but it doesn't work in production because Sonarr requests S01 explicitly and Prowlarr doesn't drop it when looking on nyaa.si
(Manual without season)
image
(Manual with season, just like request from Sonarr)
image

Anything else?

Already linked everything above

@mynameisbogdan mynameisbogdan transferred this issue from Prowlarr/Prowlarr Mar 20, 2024
ilike2burnthing added a commit to Jackett/Jackett that referenced this issue Mar 20, 2024
@ilike2burnthing
Copy link
Contributor

Jackett/Jackett@02f3175

Will be resolved in Prowlarr with the next definitions merge.

@Atakku
Copy link
Author

Atakku commented Mar 21, 2024

image
Tested the new definition, can confirm that it works

@Atakku
Copy link
Author

Atakku commented Mar 21, 2024

But I might have found a way the Sonarr compatibility feature could be improved
image
Seems it it necessary for the season number to be right after the title for it to be recognized, I think there are a couple ways to do that:

  • Check the title from the prompt, find it in the result, and inject season number right after
  • Check first bracket after the title and skip any brackets preceding the title (by assuming the title itself has no brackets), which will probably not work with titles that have brackets

@ilike2burnthing
Copy link
Contributor

Jackett/Jackett@8ba0b49

Improved Sonarr compatibility setting as per above suggestion.

S01 isn't added to any results with Movie/Movies/OVA/OAV in the title. I was going to add ONA/OAN to that list as well, but it seems to also be used for web-only series, not just specials. I wanted to add Special (and some variations) too, but that would have caught a lot of actual titles.

Will be updated in Prowlarr with next Jackett definitions merge.

@Atakku
Copy link
Author

Atakku commented Mar 21, 2024

image
Tested it, works 👍

mynameisbogdan added a commit that referenced this issue Mar 22, 2024
Towards #420

Co-authored-by: ilike2burnthing <59480337+ilike2burnthing@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants