Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP Compatibility #22

Closed
barbazul opened this issue Mar 5, 2015 · 2 comments
Closed

PHP Compatibility #22

barbazul opened this issue Mar 5, 2015 · 2 comments

Comments

@barbazul
Copy link

barbazul commented Mar 5, 2015

This is probably minor for most installs but I just run into this issue.

The module is listed as being compatible with Magento CE 1.4 which in turn is compatible with PHP 5.2

However there is a rewrite of Mage_Core_Exception that uses PHP 5.3 constructor by passing the $previous parameter.

I think the correct fix here would be to make a notice in the README notifying compatibility with PHP 5.3+ as I don't think its worth the trouble to compatibilize with PHP 5.2 as it is absolutely deprecated.
@ProxiBlue
Copy link
Owner

Hi, thanks for noting this, and I agree, no point in going backwards compatible. If someone want to do that, they can do a fork. Just no longer supported.

@ProxiBlue
Copy link
Owner

Readme updated accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@barbazul @ProxiBlue