Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New readme, docs, infra for devs #1558

Merged
merged 20 commits into from
Dec 14, 2017
Merged

New readme, docs, infra for devs #1558

merged 20 commits into from
Dec 14, 2017

Conversation

hakusaro
Copy link
Member

@hakusaro hakusaro commented Dec 14, 2017

This is the WIP branch for my initiative to revamp:

  • The readme
  • The contributing guidelines
  • Developer setup

Please give feedback on my copy and what needs to be improved or changed. I'm trying to make it look top notch 👌🏻

(Fixes #1531.)

(The markdown preview system I'm using seems to be lying to me,
so I want to see what this looks like with gfm for one commit).
@hakusaro hakusaro self-assigned this Dec 14, 2017
README.md Outdated

1. Look at the server console for the _auth code_. Type `/auth [code]` (example: `/auth 12345`), then a space, then the code you see in the console in your game chat. Instead of chatting, you'll run a command on the server. This one makes you temporary admin. All commands are prefixed with `/` or `!` (to make them silent).

1. Use the in-game command `/register [password]` (example: `/register lovely-ashes`) to create an account. This gives you owner rights on your server, which you can configure more to your liking later. Your `character name` is your `account name`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples should be consistent.
Either

/register ashes
/login shank ashes

or

/register lovely-ashes
/login shank lovely-ashes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your character name is your account name
Login to your newly created account with /login [username] [password]

Consistency would make this clearer:

Your character name is your account name
Login to your newly created account with /login [account name] [password]

or

Your character name is your username
Login to your newly created account with /login [username] [password]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're moving away from user, I've changed this to account name.

README.md Outdated

1. Login to your newly created account with `/login [username] [password]` (example: `/login shank ashes`). You should see a login success message.

1. Turn off the backdoor with `/auth-verify` and your server is setup for initial use. TShock also created several files inside a new `tshock` folder. These files include `config.json` (our big configuration file), `sscconfig.json` (the server side characters configuration file), and `tshock.sqlite`. Don't lose your `tshock.sqlite` or you'll have to re-setup TShock all over again.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turn off the backdoor

Consider revising to "Turn off the auth system"... Mentioning backdoors is never a good idea.


[...]re-setup TShock all over again

re- implies repeating, so revise to

re-setup TShock

or

setup TShock all over again

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair, the 'auth system' being turned off is not what we want to convey either. That's really bad language.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Complete first-time account setup by running ...." perhaps

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Also, see #1559.

@hakusaro hakusaro changed the title WIP: New readme, docs, infra for devs New readme, docs, infra for devs Dec 14, 2017
@hakusaro
Copy link
Member Author

Ready for review, @Pryaxis/tshock! ✨

@hakusaro
Copy link
Member Author

This bullet:

What TShock provides as an API to other plugins and what it expects other plugins to reimplement is non-clear.

I don't think I can do right now. Too much is shifting around with Bouncer to do an accurate summation of what TShock intends to provide long-term support wise to plugins. Now isn't the time to make promises we can't keep.

Copy link
Contributor

@mistzzt mistzzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Amazing!

@mistzzt mistzzt merged commit ac28a25 into general-devel Dec 14, 2017
@mistzzt mistzzt deleted the better-readme branch December 14, 2017 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants