likelihood-ratio test #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 94.16% 94.23% +0.07%
==========================================
Files 10 10
Lines 2090 2117 +27
==========================================
+ Hits 1968 1995 +27
Misses 122 122 ☔ View full report in Codecov by Sentry. |
ZetrextJG
reviewed
Jul 14, 2024
| # Since N/p_c is an integer, alpha*p_c %% N == 0 iff alpha %% (N/p_c) == 0 | ||
| # In other words, alpha must be a multiple of (N/p_1, N/p_2,...,N/p_C) | ||
| # (alpha = k*(N/p_1) or k*(N/p_2) or ... or k*(N/p_C) for some integer k (including 0)) | ||
| # However, alpha must be at most M, and a valid bound from above for integer k is max(p_1,...,p_C). |
There was a problem hiding this comment.
Here M is not defined. I know it is defined in the paper but not really in the comments
| possible_alphas <- unique(sort(alpha_matrix[alpha_matrix <= M])) | ||
|
|
||
| # Recalculate the r_alpha vector using its definition directly. |
There was a problem hiding this comment.
Just a nitpick but there is not recalculation of the r_alfa vector, this is the first time the vector is calculated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.