Prebid upgrade 3 14 0 20200401161832 #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use LiveIntent's liveconnect. Fire an event each time id is resolved. * Rename variables. Simplify imports. * Example page for LiveIntent Id module * Add application id param * Expose all possible configuration options for LiveConnect * Bumping version of live-connect-js to support: - storage manipulation provided by PBJS - ajax calls directly from PBJS * Removed spec whitespace. * Removed spec whitespace. * Removed spec for cookies * Reshuffled variables. * Re-added `findSimilarCookies` spec for further checks * Added a comment on the function to find all cookies that match a certain name. * Fixing setCookie not to include the expires as undefined. * Fixing setCookie not to include the expires as undefined. * Updated live-connect-js to 1.1.1, fixing the bug where the wrapper name was sent with an incorrect param name. PR for this change : LiveIntent/live-connect#4 The effects can be seen in the specs, where the incorrect `wrpn` sent as a pixel is now `wpn` * Removed whitespace. Co-authored-by: janko <janko.ulaga@gmail.com>
* add coppa support in quantcast adapter * fix unit tests
* Add Valueimpression Bid Adapter * Update valueimpressionBidAdapter_spec.js * Update valueimpressionBidAdapter.md * Lint valueimpressionBidAdapter.js * Update valueimpressionBidAdapter.js
* appnexus adapter : include hb_source in request to server * add unit tests * Revert "add unit tests" This reverts commit 7b6f97c. * Revert "appnexus adapter : include hb_source in request to server" This reverts commit 2a24271. * move hb_source to tag level * update if condition for adpod Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.SYNAPPNXS.local> Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.appnexus.com>
* added user sync for ix * tests for userSync iframe drop [LIBRARY-690] * fix user sync test * fix lint * added user sync info to ix bidder doc Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com> Co-authored-by: Pankaj Yadav <pankaj.yadav@indexexchange.com>
…prebid#4970) * Add microadBidAdapter * Remove unnecessary encodeURIComponent from microadBidAdapter * Submit Advangelists Prebid Adapter * Submit Advangelists Prebid Adapter 1.1 * Correct procudtion endpoint for prebid * analytics update with wrapper name * reverted error merge * update changed default value of netRevenue to true * Re-add rubicon analytics without deprecated getTopWindowUrl util * Cache referrer on auction_init instead of bid_requested * add gdprScope config support * add tests * updated with requested changes from the pull request * optimization to simplify setting the gdprApplies value Co-authored-by: nakamoto <nakamoto_tatsuya@microad.co.jp> Co-authored-by: Chandra Prakash <chandra.prakash@advangelists.com> Co-authored-by: Eric Harper <eharper@rubiconproject.com> Co-authored-by: TJ Eastmond <teastmond@la-wlandaverde-mac.local> Co-authored-by: Mark Monday <mmonday@rubiconproject.com> Co-authored-by: msm0504 <51493331+msm0504@users.noreply.github.com>
* Added Adnuntius Bid Adapter * Changes to Adnuntius bidder according to comments. * Fixed non used variable warning. * Fixed outstanding issues * Fixed issue in test and bidder. * Fixed all the "for ... of" Issues.
Co-authored-by: Jaimin Panchal <email@example.com>
* added support for pubcommon, digitrust, id5id * added support for IdentityLink * changed the source for id5 * added unit test cases * changed source param for identityLink * PubMatic to support NetId UserId sub-module
* * Update undertone adapter - change parameters - placementId parameter is now optional and not mandatory - undertoneBidAdapter.js * Updated undertone bid adapter tests accordingly - undertoneBidAdapter_spec.js * * Update undertone adapter - change parameters - placementId parameter is now optional and not mandatory - undertoneBidAdapter.js * Updated undertone bid adapter tests accordingly - undertoneBidAdapter_spec.js * fix lint issue in undertone adapter spec * added user sync function to undertone adapter * * Update undertone adapter - change parameters - placementId parameter is now optional and not mandatory - undertoneBidAdapter.js * Updated undertone bid adapter tests accordingly - undertoneBidAdapter_spec.js * added user sync function to undertone adapter * added user sync function to undertone adapter * revert package-lock.json * send element coordinates and viewport * Update undertoneBidAdapter.js * add null in case of no data easier integration with earlier versions * update according to fixes * added user sync function to undertone adapter * Update undertoneBidAdapter.js * remove unneded changes after rebase Co-authored-by: omerko <omer.koren@perion.com> Co-authored-by: Omer Koren <omerko@users.noreply.github.com>
* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1) * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter * ET-1691: cleanup * ET-1691: minor * ET-1691: revert package.json change * Adding bidRequest to bidFactory.createBid method as per prebid#509 * ET-1765: Adding support for additional params in PulsePoint adapter (#2) * ET-1850: Fixing prebid#866 * Minor fix * Adding mandatory parameters to Bid * PulsePoint: support for banner.format object * AdSize on response for banner responses * Fixing review comment * Reverting package-json changes
* New adfinity adapter * Update adfinityBidAdapter.md * add test params * native response validattion * fix secure param * gdpr support * fix merge conflict Co-authored-by: Aiholkin <artem.iholkin@smartyads.com> Co-authored-by: root <root@localhost.localdomain>
* adds Media.net Analytics Adapter * fixes medianet adapter key in docs Co-authored-by: vedant.s <vedant.s@media.net>
* Cambia nome variabile us privacy in getUserSyncs * Onetag bid adapter: Added video support and minor code refactoring * Fix for linter * Onetag Bid Adapter: code refactoring, added testing params and updated adapter tests * Onetag Bid Adapter: minor code refactoring Co-authored-by: valentino <v.v@v.v> Co-authored-by: Nicola <ciao@ciao>
* Add files via upload * Add files via upload * Update platformioBidAdapter.js
* added config option to enabled alias syncs * added unit test
* Between: multisizes support added * rollback package-lock.json Co-authored-by: Ignat Khaylov <khaylov@betweenx.com>
Co-authored-by: Francisco Monzon <francisco.monzon@mbp-op-383.local>
* Added new sizes * Changed 257 key to 258
* first commit :) * added event handlers * in-dev chnages, need to remove a lot of code * moved strings to const * still in-dev * added profileId profileVersionId in config * added some todos * added support for pubcommon, digitrust, id5id * added support for IdentityLink * changed the source for id5 * added unit test cases * changed source param for identityLink * corrected end-points and size formatting * fixed db flag * dealId and dealChannel are set * passing kgpv * passing ocpm and ocry * commented un-necessary code, to be deleted later * added a todo * marking wb and added some const * in-dev changes * in-dev changes * bid-win logger added * deleted un-necessary code * adding a unit-test code * writing unit test cases * default value for l1 * writing some more unit test cases * unit test case for timeout case * logger currency unit test case added * execute win-tracker using ajax * win-tracker unit test case * fixed a typo * added pdomain in logger call * l1 should be 0 if no response (needs secnd thought) * added bidderDonePendingCount logic and a todo * changed pdomain to orig * added gdpr support, unit test cases pending * moved some code to new setMediaTypes function * added a new function getHighestBidForAdUnit * moved some code to a function * added GDPR related unit test case but this case-data always adds gdpr config to request * removed a todo * removed un-necessary objects * default timeout = 2000ms removed unnecessary code * execute logger at 500ms if all bidders have responded else 2000ms * removed reference of utils.getTopWindowUrl * tst should be in seconds; updated test cases as well * added kgpsv in logger call * gdpr flag fix * originalCpm and originalCurrency * added test cases * chnaged logic for ss field, also changed test cases to always s2s * moved s2sBidders setting logic to auction init
…rebid#5010) * BritePool ID * CriteoID * DigiTrust * ID5 ID * LiveIntent ID * netID * Parrable ID Co-authored-by: Harman Goei <5001432+hrgui@users.noreply.github.com>
Co-authored-by: Xavier Leune <xleune@ccmbenchmark.com>
Fix to other discovered issues of DigiTrust ID failing to write into userId system. Adjust samples to call https pages in all cases for testing purposes.
* added support for pubcommon, digitrust, id5id * added support for IdentityLink * changed the source for id5 * added unit test cases * changed source param for identityLink * disabled a test case causing test-suite refresh
* Price Floors (#52) * Initial Commit Code cleanup + PBS Changes + tests still needed * Refactor to remove event * forgot to remove FLOOR_NOT_MET * Clean up code * broke out req params * floorNotMet is not bidRejected * clean up module, more requirements on bid and analytics adapters moved gpt matching into a util function * test updates + currency conversion now on global * asdf * floor data object schema changed updated to object not array * Selection function now needs to sort by number of *'s in the rule Rubicon get video floor use actual player size * Updated json schema * tests finished * domain is more sophisticated now * Currency floors refactored a little Added log for when bid is floored * update tests after additional data passed to analytics * analytics reqs updated * test update * update to cache lookups Analytics adapter update tests updated for cache lookup * reverting temp stuff * Pulling latest from master = few probs Small currency bug * revert newline * improved rule selection for getFloor * new api for adding new fields overrides if debug on, resp hook after debug hook small bug in overwriting data object * handle adjustment factor of 0 * removed size and mt specific logic and pushed to matching func * adding comments for all funcs * Added tests for rubicon adapters handle matchign keys with dot's * undefined data should be ignored * remove unnecessary -1 plus semi colon * md file * removing temp test file * prebid uses native image size as a single array so we wrap it * Forgot IE 11 no have includes! * if enforcement not passed in default it Exact match not found, then * * no need to decode uri entire url when just wanting hostname * setting auctionId on bidRequests so `onBeforeRequestBids` has context for getFloor() * rubi analytics new values * js rounding fix + isNaN handling * random parenthesis * fixing formula Co-authored-by: rmartinez <Rachael24!>
* Add support for userid modules in Yieldlab adapter * Change for-of-loop for IE11 compatibility * Check if userIdAsEids is an array
Co-authored-by: Jaimin Panchal <email@example.com>
Co-authored-by: tadam75 <tadam@smartadserver.com>
* TCF Purpose 1 enforcement * some more unit tests and revert hello world page * some updates and unit test * remove unwanted comment * Adapter updates and some refactoring * add expires for ie11 * adding withCredentials false to appnexus adapter * improving conditions * improving conditions * Including changes for liveintent Co-authored-by: Jaimin Panchal <email@example.com>
Co-authored-by: Jaimin Panchal <email@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information