Avoid that cmake removes variables from pkg-config file #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice catch |
|
thanks |
opdenkamp
pushed a commit
that referenced
this pull request
Jan 18, 2016
Avoid that cmake removes variables from pkg-config file
|
@opdenkamp , due to Kodi Jarvis keeping the old package name for now (no p8 prefix), is it safe to apply this patch to the latest on the releases page, or what is your advice? |
|
yeah the code is the same thing for these two, it's just the names that changed. so you can backport this patch if you remove the |
|
@ProfessorKaos64 see https://github.com/Pulse-Eight/platform/releases/tag/platform-2.0.1 (backported this patch onto the hash before the name change) |
|
@opdenkamp thank you very much. This saves me the trouble of adding a patch with quilt. A more clean approach. |
mdeguzis
added a commit
to mdeguzis/LibreGeek-Packaging
that referenced
this pull request
Jan 19, 2016
|
Confirmed working for me for my needs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently cmake will remove the variables from the p8-platform.pc when running
configure_file, leading to a-Iargument without a value in Cflags.