-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pallet referenda migration for referendumInfo #2134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbaztec
added
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
D5-nicetohaveaudit⚠️
PR contains trivial changes to logic that should be properly reviewed.
breaking
Needs to be mentioned in breaking changes
labels
Feb 27, 2023
crystalin
requested review from
librelois and
girazoki
and removed request for
librelois
February 27, 2023 09:11
librelois
approved these changes
Feb 27, 2023
girazoki
reviewed
Feb 27, 2023
girazoki
approved these changes
Feb 27, 2023
Co-authored-by: girazoki <gorka.irazoki@gmail.com>
librelois
added a commit
that referenced
this pull request
Feb 27, 2023
* add pallet referenda migration * add migration to moonbase and moonriver only * fix wrong file * fix benchmarks compilation * Update runtime/moonbeam/src/lib.rs Co-authored-by: girazoki <gorka.irazoki@gmail.com> --------- Co-authored-by: librelois <c@elo.tf> Co-authored-by: girazoki <gorka.irazoki@gmail.com>
crystalin
changed the title
[MOON-2215] add pallet referenda migration
Add pallet referenda migration for referendumInfo
Feb 27, 2023
nbaztec
added
the
D1-runtime-migration
PR introduces code that might require downstream chains to run a runtime upgrade.
label
Apr 12, 2023
notlesh
added
D1-audited👍
PR contains changes to fund-managing logic that has been properly reviewed and externally audited
and removed
D5-nicetohaveaudit⚠️
PR contains trivial changes to logic that should be properly reviewed.
labels
Apr 26, 2023
2 tasks
imstar15
pushed a commit
to AvaProtocol/moonbeam
that referenced
this pull request
May 16, 2023
* add pallet referenda migration * add migration to moonbase and moonriver only * fix wrong file * fix benchmarks compilation * Update runtime/moonbeam/src/lib.rs Co-authored-by: girazoki <gorka.irazoki@gmail.com> --------- Co-authored-by: librelois <c@elo.tf> Co-authored-by: girazoki <gorka.irazoki@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
breaking
Needs to be mentioned in breaking changes
D1-audited👍
PR contains changes to fund-managing logic that has been properly reviewed and externally audited
D1-runtime-migration
PR introduces code that might require downstream chains to run a runtime upgrade.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
adds pallet referenda migration to v1. The migration was introduced in paritytech/substrate#12788 and was missing in the release notes and the correct labels. The
ReferendumInfo
type is migrated to the newer version to allow refunding deposits.The following invariants of
ReferendumInfo
-Approved
,Rejected
,Cancelled
,TimedOut
now have their second parameter optional,Option<Deposit<AccountId, Balance>>
, which was previouslyDeposit<AccountId, Balance>
.SubmissionDepositRefunded