Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim entities and POI chunks #15

Merged
merged 5 commits into from Jul 1, 2022
Merged

Trim entities and POI chunks #15

merged 5 commits into from Jul 1, 2022

Conversation

ghost
Copy link

@ghost ghost commented Feb 10, 2022

I made a mistake with my PR #13 and I can't edit it, sorry. 😅
Here's a new one, still to fix issue #12.

Note to myself : Deleting a fork before the PR is finished isn't a good idea, because you can't edit it again.

Sailoriae and others added 5 commits February 9, 2022 16:59
To make it simple and not refactor everything, it's an option of the "trim" command
It's better and easier for the user
Co-authored-by: Dylan Xaldin <Puremin0rez515@gmail.com>
Co-authored-by: Dylan Xaldin <Puremin0rez515@gmail.com>
@Puremin0rez Puremin0rez added bug Something isn't working enhancement New feature or request labels Feb 10, 2022
@ghost
Copy link
Author

ghost commented Apr 22, 2022

🤔 Up ? ^^

@Puremin0rez
Copy link
Owner

I apologize for the late reply, I have been very busy with work.

I will be releasing a new version of WorldBorder for 1.19 sometime within the next few weeks, and I will review this PR and perform thorough testing before then. If the review goes well and all functionality works as expected, I hope to get this PR merged in for the upcoming release.

@Puremin0rez Puremin0rez merged commit adebee7 into Puremin0rez:master Jul 1, 2022
@Puremin0rez
Copy link
Owner

Puremin0rez commented Jul 1, 2022

I have performed hours of testing across multiple different worlds of varying sizes and your PR has successfully passed all of my tests. I have merged your changes into the master branch and they will be available to everyone in the next release.

Thank you once again for your high quality contribution, it's greatly appreciated!

@ghost
Copy link
Author

ghost commented Jul 1, 2022

Hello,
Great, congratulations ! Thank you very much for your tests, I havn't done so many. I'm glad that my code works so well, and brings something to this project.
Have a nice day ! ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant