I 134 ui should go nuts when a user completes a task #231
Conversation
| this.setState({ | ||
| 'triggerToast': false | ||
| }); | ||
| } |
There was a problem hiding this comment.
Assumed so... Turns out not :)
| @@ -51,6 +77,7 @@ class TaskStatus extends Component { | |||
| const { status } = this.props; | |||
| return ( | |||
| <div className={"task-status-ctn task-status-" + status + " hide-small"}> | |||
| <Confetti active={ this.state.triggerToast } config={ config }/> | |||
There was a problem hiding this comment.
@4xdk {NoSpaces} around the { braces }, please
| @@ -18,8 +18,34 @@ const STATUS_IMAGES = { | |||
| 'WorkingOn': true, | |||
| } | |||
|
|
|||
| const config = { | |||
There was a problem hiding this comment.
@4xdk How about calling this confettiConfig instead?
|
The only slight issue is that when sidebar is open, BOTH TaskStatus elements show confetti. This is actually not visible (unless you hack the dom/css with dev tools to move the sidebar), just FYI. |
|
@4xdk Are you saying that half the confetti is thrown behind the right panel, so to speak? |
|
@elimisteve Yeah. There's double the amount to begin with, so end visual effect is the same. There could be some additional wizardry we could do to prevent showing on both (like checking if sidebar is open maybe ?) Just not sure if it's worth it, since we can't really see the problem. |
|
Yeah let's not worry about it right now, but good point; I'll keep this in
mind 👍 .
…On Sun, Jul 29, 2018 at 11:28 PM, 4xdk ***@***.***> wrote:
@elimisteve <https://github.com/elimisteve> Yeah. There's double the
amount to begin with, so end visual effect is the same.
There could be some additional wizardry we could do to prevent showing on
both (like checking if sidebar is open maybe ?) Just not sure if it's worth
it, since we can't really see the problem.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#231 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIhU9Gg6Nr_UiMiKvV02bTlx5sJCITNks5uLqeegaJpZM4Vk9XD>
.
|
Totally not sure if this is the right way (local component state) but seems to me like dispatching actions for this would overcomplicate things(?).