Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] With Ready Set Roll it duplicates the chat message for feature/spell on item #22

Closed
Dalton1310 opened this issue Oct 14, 2023 · 5 comments · Fixed by #39
Closed
Assignees
Labels
enhancement New feature or request module compatibility It's about other module compatibility

Comments

@Dalton1310
Copy link

Module Version: v1.3.2

Describe the bug
This bug creates 2 chat logs for every time you use a feature or spell and makes nulls one of the chat logs ability to make targets roll save, take damage, heal, or apply effect.

To Reproduce
Steps to reproduce the behavior:

  1. Create an item
  2. Give the item a spell or feature
  3. Give the item to a character
  4. Have the character use the spell or feature
  5. 2 chat logs of that spell or feature shows up and only one can be used, the other is an error

Expected behavior
The item feature/spell should only give one chat prompt that allows targets to click on to roll for a save, as well as to click on if there is an effect to give if they fail. This bug also removes the most current chat of the two saying that it isn't attached to an item anymore

Screenshots
1
2
image
image
That one is if you click the lower chat log save.
image

Foundry Version: Version 11, latest Module update

Additional context
Ready Set Roll 2.1.2 is the only module that does anything with chat logs for features and spells.

@Dalton1310 Dalton1310 added the bug Something isn't working label Oct 14, 2023
@PwQt PwQt self-assigned this Oct 14, 2023
@Dalton1310
Copy link
Author

This was left in magic items 1 as a comment that may possibly solve the issue?
"Hey I just stumbled into this issue not being solved after 2 months. As a fellow developer I know it is easy to throw "compatibility issue" onto other software, but I think the solution here is fairly simple.
I glanced through the code for the module and found code that seem to cause the issue. In OwnedMagicItemSpell.roll().proceed() it calls ChatMessage.create(_) directly, so adding simple condition check here to not post your own message when RSR is enabled would probably solve all issues with doubled chat card."

@p4535992 p4535992 added enhancement New feature or request module compatibility It's about other module compatibility and removed bug Something isn't working labels Dec 30, 2023
@david-simoes-93
Copy link

@PwQt
Copy link
Owner

PwQt commented Jan 6, 2024

Should be fixed in 1.4.0

@PwQt PwQt closed this as completed Jan 6, 2024
@Dalton1310
Copy link
Author

This did not seem to work for me, updating to 1.4.0 but thank you for the effort!

@david-simoes-93
Copy link

Issue still exists in 1.4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module compatibility It's about other module compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants