Set time_base for AudioResampler #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we please have a test for this? |
daveisfera
force-pushed
the
resampler_time_base
branch
from
74983f8
to
b9dea11
Compare
daveisfera
force-pushed
the
resampler_time_base
branch
from
b9dea11
to
c668165
Compare
daveisfera
force-pushed
the
resampler_time_base
branch
from
c668165
to
b4a5085
Compare
|
I added tests and allowed them to run to show that it's broken and then pushed the fix to show it's working now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1182 (redo of #1184)