Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hacking Facebook lecture TWP45 #102

Merged
merged 2 commits into from
Jun 25, 2021

Conversation

AngelaRemolina
Copy link
Collaborator

@AngelaRemolina AngelaRemolina commented Jun 16, 2021

Summary

This PR closes AngelaRemolina#8 :

  1. A new Brython module for Runestone was implemented. That is why the requirements.txt file is changed to load the customized Runestone version.
    To do the runestone component the following steps were followed:
  1. A proof exercise of the lecture TWP45 "Hackeando Facebook con Python", was made using the new Brython module

This PR also resolves AngelaRemolina#7 with a playwright test that checks the image is displayed correctly.

Note: Exercises that did not work due to access to the Facebook API have been removed. More exercises still need to be implemented in this lecture on the future.

Checklist

  • Variables, functions and comments are translated to Spanish
  • Functions follow underscore notation
  • Spell check done & typos fixed
  • All python code is PEP8 compliant
  • Test coverage with Playwright implemented; locators are Pyhton code
  • Reviewers assigned (all peers & at least 1 mentor)

Note: Only the iframe locator is with XPath. I wasn't able to locate it other way but I'm sure that XPath won't change because of the runestone template for activecode blocks. If you have any suggestion I'd be happy to implement them :)

Screenshots

test_l45_1_chromium.mp4

@github-actions
Copy link

Copy link
Collaborator

@LeoCumpli21 LeoCumpli21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! It is amazing. With this implemented we can begin to explore the lectures that currently don't work. Well done :)

Copy link
Collaborator

@y-martinez y-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! it works like a charm. Like I said before, maybe will be great to change the name the lecture to another one :)

@AngelaRemolina
Copy link
Collaborator Author

Nice! it works like a charm. Like I said before, maybe will be great to change the name the lecture to another one :)

Yes, I think in the future when more exercises are added to this lecture, we can change its name :)

Copy link

@Devilish19 Devilish19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Member

@NicolasSandoval NicolasSandoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a marvelous work, congrats!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants