-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hacking Facebook lecture TWP45 #102
Hacking Facebook lecture TWP45 #102
Conversation
Published to http://pyar.github.io/PyZombis/102/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! It is amazing. With this implemented we can begin to explore the lectures that currently don't work. Well done :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! it works like a charm. Like I said before, maybe will be great to change the name the lecture to another one :)
Yes, I think in the future when more exercises are added to this lecture, we can change its name :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a marvelous work, congrats!
…ercise Hacking Facebook lecture TWP45
Summary
This PR closes AngelaRemolina#8 :
requirements.txt
file is changed to load the customized Runestone version.To do the runestone component the following steps were followed:
activecode_brython.js
was created with a html template that loads the Brython and attach the code to it: Add the html elements as a template needed for Brython AngelaRemolina/RunestoneComponents#4python3_interpreter
as an activecode option: Python3_interpreter activecode directive AngelaRemolina/RunestoneComponents#5print()
and errors is being built: Console displaying errors and prints in a <pre> tag AngelaRemolina/RunestoneComponents#11This PR also resolves AngelaRemolina#7 with a playwright test that checks the image is displayed correctly.
Note: Exercises that did not work due to access to the Facebook API have been removed. More exercises still need to be implemented in this lecture on the future.
Checklist
Note: Only the iframe locator is with XPath. I wasn't able to locate it other way but I'm sure that XPath won't change because of the runestone template for activecode blocks. If you have any suggestion I'd be happy to implement them :)
Screenshots
test_l45_1_chromium.mp4