Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lecture TWP30: Revisión general 1 (define colors) #128

Merged
merged 2 commits into from
Jul 17, 2021
Merged

Update lecture TWP30: Revisión general 1 (define colors) #128

merged 2 commits into from
Jul 17, 2021

Conversation

AngelaRemolina
Copy link
Collaborator

@AngelaRemolina AngelaRemolina commented Jul 11, 2021 •
edited
Loading

Summary

This PR partially closes AngelaRemolina#15 and resolves visual details left in #117

  1. The color references is fixed. An html directive is used to highlight the code with the same colors on activecode blocks.
  2. Repeated slides titles are deleted.

Checklist

  • Variables, functions and comments are translated to Spanish
  • Functions follow underscore notation
  • Spell check done & typos fixed
  • All python code is PEP8 compliant
  • Test coverage with Playwright implemented; locators are Pyhton code
  • Reviewers assigned (all peers & at least 1 mentor)

Screenshots

image

@github-actions
Copy link

Published to http://pyar.github.io/PyZombis/128/index.html

@AngelaRemolina AngelaRemolina mentioned this pull request Jul 11, 2021
Closed
LeoCumpli21
LeoCumpli21 approved these changes Jul 12, 2021
View reviewed changes
Copy link
Collaborator

@LeoCumpli21 LeoCumpli21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

y-martinez
y-martinez approved these changes Jul 13, 2021
View reviewed changes
Copy link
Collaborator

@y-martinez y-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@AngelaRemolina AngelaRemolina changed the title Update TWP30.rst Update lecture TWP30: Revisión general 1 (define colors) Jul 16, 2021
@github-actions
Copy link

Published to http://pyar.github.io/PyZombis/128/index.html

NicolasSandoval
NicolasSandoval approved these changes Jul 17, 2021
View reviewed changes
Copy link
Member

@NicolasSandoval NicolasSandoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thanks!

@NicolasSandoval NicolasSandoval merged commit 3bb6c63 into PyAr:master Jul 17, 2021
@AngelaRemolina AngelaRemolina deleted the TWP30 branch July 18, 2021 00:10
reingart pushed a commit that referenced this pull request Oct 27, 2021
@NicolasSandoval
Merge pull request #128 from angelasofiaremolinagutierrez/TWP30
0592e04 
Update lecture TWP30: Revisión general 1 (define colors)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoCumpli21 LeoCumpli21 LeoCumpli21 approved these changes

@NicolasSandoval NicolasSandoval NicolasSandoval approved these changes

@y-martinez y-martinez y-martinez approved these changes

@reingart reingart Awaiting requested review from reingart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review repeated, not copyright-free, and not spanish content (from TWP05 to TWP38)
4 participants
@AngelaRemolina @y-martinez @NicolasSandoval @LeoCumpli21