Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code screenshots and slides titles from lectures TWP05 to TWP38 #129

Merged
merged 11 commits into from
Jul 20, 2021
Merged

Remove code screenshots and slides titles from lectures TWP05 to TWP38 #129

merged 11 commits into from
Jul 20, 2021

Conversation

AngelaRemolina
Copy link
Collaborator

@AngelaRemolina AngelaRemolina commented Jul 11, 2021 •
edited
Loading

Summary

This PR partially closes AngelaRemolina#15
Fixed:

  1. Repeated titles (slides titles) are removed (all lectures from TWP05 to TWP38).
  2. An image of a table was replaced by a rst table on lecture TWP15.
  3. Small bug left on TWP05 fixes #127 with TWP05 backticks (``) problem
  4. Code screenshots were replaced by code-blocks or activecode blocks in TWP33 and TWP38.
  5. A unit test was implemented for exercise on lecture TWP38. Please note: that last test could not be done with library TestCaseGui given that Brython does not support it. I had to use only unittest.

Note: This might look like a large PR, but it is mostly because I'm deleting duplicated text. Real important changes are in files: TWP15 (table), TWP33 and TWP38 (replacing code screenshots and unit test).

Checklist

  • Variables, functions and comments are translated to Spanish
  • Functions follow underscore notation
  • Spell check done & typos fixed
  • All python code is PEP8 compliant
  • Test coverage with Playwright implemented; locators are Pyhton code
  • Reviewers assigned (all peers & at least 1 mentor)

@AngelaRemolina AngelaRemolina mentioned this pull request Jul 11, 2021
Closed
@github-actions
Copy link

Published to http://pyar.github.io/PyZombis/129/index.html

@github-actions
Copy link

Published to http://pyar.github.io/PyZombis/129/index.html

LeoCumpli21
LeoCumpli21 approved these changes Jul 12, 2021
View reviewed changes
Copy link
Collaborator

@LeoCumpli21 LeoCumpli21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@AngelaRemolina @LeoCumpli21
Update _sources/lectures/TWP38.rst
e0fdee7 
Co-authored-by: Leonardo Cumplido <cumplileo@gmail.com>
@github-actions
Copy link

Published to http://pyar.github.io/PyZombis/129/index.html

y-martinez
y-martinez approved these changes Jul 13, 2021
View reviewed changes
Copy link
Collaborator

@y-martinez y-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor suggestion, however, LGTM 🚀

_sources/lectures/TWP17.rst Outdated Show resolved Hide resolved
AngelaRemolina and others added 2 commits July 14, 2021 18:01
@AngelaRemolina @y-martinez
Update _sources/lectures/TWP17.rst
f4908b2 
Co-authored-by: Ybrahin Martinez <martinez.ybrahin@gmail.com>
@AngelaRemolina
Suggestion
e511b69
@github-actions
Copy link

Published to http://pyar.github.io/PyZombis/129/index.html

1 similar comment
@github-actions
Copy link

Published to http://pyar.github.io/PyZombis/129/index.html

eamanu
eamanu reviewed Jul 18, 2021
View reviewed changes
_sources/lectures/TWP17.rst Outdated Show resolved Hide resolved
_sources/lectures/TWP23.rst Outdated Show resolved Hide resolved
AngelaRemolina and others added 3 commits July 19, 2021 15:00
@AngelaRemolina @eamanu
Update _sources/lectures/TWP17.rst
1146ed4 
Co-authored-by: Emmanuel Arias <eamanu@yaerobi.com>
@AngelaRemolina @eamanu
Update _sources/lectures/TWP23.rst
26bb386 
Co-authored-by: Emmanuel Arias <eamanu@yaerobi.com>
@AngelaRemolina
delete whitespaces
0ebde9f
@github-actions
Copy link

Published to http://pyar.github.io/PyZombis/129/index.html

2 similar comments
@github-actions
Copy link

Published to http://pyar.github.io/PyZombis/129/index.html

@github-actions
Copy link

Published to http://pyar.github.io/PyZombis/129/index.html

@github-actions
Copy link

Published to http://pyar.github.io/PyZombis/129/index.html

NicolasSandoval
NicolasSandoval approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@NicolasSandoval NicolasSandoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks.

@NicolasSandoval NicolasSandoval merged commit 3588c9d into PyAr:master Jul 20, 2021
@AngelaRemolina AngelaRemolina deleted the code-screenshots branch July 20, 2021 22:22
reingart pushed a commit that referenced this pull request Oct 27, 2021
@NicolasSandoval
Merge pull request #129 from angelasofiaremolinagutierrez/code-screen…
2280ad7 
…shots

Remove code screenshots and slides titles from lectures TWP05 to TWP38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamanu eamanu eamanu left review comments

@LeoCumpli21 LeoCumpli21 LeoCumpli21 approved these changes

@NicolasSandoval NicolasSandoval NicolasSandoval approved these changes

@y-martinez y-martinez y-martinez approved these changes

@reingart reingart Awaiting requested review from reingart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review repeated, not copyright-free, and not spanish content (from TWP05 to TWP38)
5 participants
@AngelaRemolina @y-martinez @eamanu @NicolasSandoval @LeoCumpli21