Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction video on index #130

Merged
merged 3 commits into from
Jul 19, 2021
Merged

Conversation

AngelaRemolina
Copy link
Collaborator

@AngelaRemolina AngelaRemolina commented Jul 13, 2021

Summary

This PR resolves AngelaRemolina#19

  • The section called: Índices y tablas is removed
  • An introduction video is inserted on top of the content menu.
  • The main title is centered

Note: This video is the Portuguese version of the introduction to the course. Once we have the video translated into Spanish, we can change the source of the video.

Checklist

  • Variables, functions and comments are translated to Spanish
  • Functions follow underscore notation
  • Spell check done & typos fixed
  • All python code is PEP8 compliant
  • Test coverage with Playwright implemented; locators are Pyhton code
  • Reviewers assigned (all peers & at least 1 mentor)

Screenshots

image

@github-actions
Copy link

Copy link
Collaborator

@y-martinez y-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM! 🚀 however, is it possible to align to the center, maybe using :align: center ?

@AngelaRemolina
Copy link
Collaborator Author

AngelaRemolina commented Jul 14, 2021

In general LGTM! 🚀 however, is it possible to align to the center, maybe using :align: center ?

@y-martinez I tried to align it center just like you said with :align: center. But this instruction does not seem to work.

Here is an example:
Source: https://github.com/RunestoneInteractive/InstructorGuide/blob/master/_sources/CustomCourses/createCourse.rst
image

Deploy: https://runestone.academy/runestone/books/published/instructorguide/CustomCourses/createCourse.html
image

I will use the .. raw:: html instruction to center it.

@github-actions
Copy link

@github-actions
Copy link

@NicolasSandoval NicolasSandoval merged commit b54b58e into PyAr:master Jul 19, 2021
@AngelaRemolina AngelaRemolina deleted the intro-video branch July 20, 2021 22:23
reingart pushed a commit that referenced this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add introduction video on index
5 participants