Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor lecture TWP42: Bases de datos (sql.js approach) #184

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AngelaRemolina
Copy link
Collaborator

@AngelaRemolina AngelaRemolina commented Aug 13, 2021

Summary

This PR may close: AngelaRemolina#48
I have implemented another approach (better than tha one on this PR to refacto this lecture.
I use sql.js library for SQLite compiled to JavaScript. I load create the original surfersDB from the PyZombis course using the .. raw:: html tag as a global variable.

I'm still working on accessing this global variable from the activecode block with Brython. But I can confirm the db is global since in the browser console you can print it (see image below)

Checklist

  • Variables, functions and comments are translated to Spanish
  • Functions follow underscore notation
  • Spell check done & typos fixed
  • All python code is PEP8 compliant
  • Test coverage with Playwright implemented; locators are Pyhton code
  • Reviewers assigned (all peers & at least 1 mentor)

Note: debug prints and some comments for the draft PR have not been deleted yet. Is still on progress.

Screenshots

image

@github-actions
Copy link

@AngelaRemolina AngelaRemolina changed the title [WIP] Refactor lecture TWP42: Bases de datos (sql.js approach) Refactor lecture TWP42: Bases de datos (sql.js approach) Aug 21, 2021
@shivamshan
Copy link
Collaborator

Hi @angelasofiaremolinagutierrez , based on your PR i made some changes in ..raw:: html tag and now we can access the sql.js db using document module provide by activecode. Have a look at this PR #200 . I think we can use this to move forward with the lectures. Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review Bases de datos lecture
2 participants