Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiz numeration #190

Merged
merged 13 commits into from
Aug 15, 2021
Merged

Quiz numeration #190

merged 13 commits into from
Aug 15, 2021

Conversation

AngelaRemolina
Copy link
Collaborator

@AngelaRemolina AngelaRemolina commented Aug 15, 2021

Summary

Since quiz 8 did not exist, the quiz numeration change moving from:

  • quiz9 to quiz8
  • quiz10 to quiz9
  • quiz11 to quiz10
  • quiz12 to quiz11
  • quiz13 to quiz12
  • quiz14 to quiz13

And its respective tests changed in the same way.

Checklist

  • Variables, functions and comments are translated to Spanish
  • Functions follow underscore notation
  • Spell check done & typos fixed
  • All python code is PEP8 compliant
  • Test coverage with Playwright implemented; locators are Pyhton code
  • Reviewers assigned (all peers & at least 1 mentor)

Screenshots

image

@github-actions
Copy link

@github-actions
Copy link

Copy link
Member

@NicolasSandoval NicolasSandoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks.

@NicolasSandoval NicolasSandoval merged commit 3d5d4b3 into PyAr:master Aug 15, 2021
reingart pushed a commit that referenced this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants