Mejoras en las páginas de solicitud de alta #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzulberti
reviewed
Sep 10, 2020
| # test that it show only human-related categories | ||
| cat = Category.objects.create(name=Category.BENEFACTOR_GOLD, description='', fee=500) | ||
| response = self.client.get(reverse('signup_person')) | ||
| self.assertNotIn(cat, response.context_data['categories']) |
There was a problem hiding this comment.
Cat en este caso es un objecto... Como funciona el in en esos casos?
There was a problem hiding this comment.
No sé exactamente la teoría de qué hace el objeto de Django ahí... pero funciona, porque hice el test primero, fallaba, y luego excluí esa categoría y empezó a pasar ok. O sea que el "in" funcionaba bien (el objeto debe hashearse por algo que tenga sentido, etc)
tzulberti
approved these changes
Sep 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
En general:
En la de personas:
En la de organizaciones:
Mostrar las categorías
Incluí el texto correspondiente del estatuto
Puse un link al folleto de beneficios