Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type annotations and validate with pyright #262

Merged
merged 6 commits into from
May 29, 2023
Merged

Add type annotations and validate with pyright #262

merged 6 commits into from
May 29, 2023

Commits on May 29, 2023

  1. Drop Python 3.7

    @fsouza
    fsouza committed May 29, 2023
    Configuration menu
    Copy the full SHA
    7fa5675 View commit details
    Browse the repository at this point in the history

  2. Add type annotations

    @fsouza
    fsouza committed May 29, 2023
    Configuration menu
    Copy the full SHA
    8b87237 View commit details
    Browse the repository at this point in the history

  3. Add pyright to pre-commit config 

    Also configure reorder-python-imports to add annotations import
everywhere.
    @fsouza
    fsouza committed May 29, 2023
    Configuration menu
    Copy the full SHA
    eef3819 View commit details
    Browse the repository at this point in the history

  4. github/workflows/main: install the package for pre-commit 

    This is required for properly running pyright. Unfortunately, it also
means we cannot use pre-commit CI anymore.
    @fsouza
    fsouza committed May 29, 2023
    Configuration menu
    Copy the full SHA
    c687244 View commit details
    Browse the repository at this point in the history

  5. Add py.typed

    @fsouza
    fsouza committed May 29, 2023
    Configuration menu
    Copy the full SHA
    ab37b11 View commit details
    Browse the repository at this point in the history

  6. github/workflows/main: explicitly install tomli for pyright

    @fsouza
    fsouza committed May 29, 2023
    Configuration menu
    Copy the full SHA
    4e83370 View commit details
    Browse the repository at this point in the history