Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option to remove RHS also when removing unused variables #92

Merged
merged 1 commit into from
Aug 28, 2022

Conversation

das-intensity
Copy link
Contributor

close #91

@fsouza
Copy link
Collaborator

fsouza commented Aug 27, 2022

@das-intensity thanks for contributing! Can you resolve the conflicts?

@das-intensity
Copy link
Contributor Author

@fsouza Done :) I also tried to match the formatting a little better, but am unclear on some of the stylings so let me know if you'd prefer some different whitespace config somewhere.

@fsouza
Copy link
Collaborator

fsouza commented Aug 28, 2022

@fsouza Done :) I also tried to match the formatting a little better, but am unclear on some of the stylings so let me know if you'd prefer some different whitespace config somewhere.

For style, if pre-commit is happy I'm happy haha If the build fails you can run pre-commit run -a

@das-intensity das-intensity force-pushed the feature/drop-rhs-on-unused-var branch 2 times, most recently from 0be0ec9 to b754f6b Compare August 28, 2022 23:08
@das-intensity
Copy link
Contributor Author

Ahh thanks, I hadn't used pre-commit before. All issues fixed there. Please cancel run 71 but 72 should be good to go.

Copy link
Collaborator

@fsouza fsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! Just one thing and I think it should be good to go.

autoflake.py Show resolved Hide resolved
@fsouza fsouza merged commit 3aed3dd into PyCQA:master Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to drop RHS when removing unused variables
2 participants