Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Python 2 #584

Closed
lukehinds opened this issue Mar 7, 2020 · 6 comments · Fixed by #615 or #674
Closed

Deprecate Python 2 #584

lukehinds opened this issue Mar 7, 2020 · 6 comments · Fixed by #615 or #674
Assignees
@lukehinds
Labels
enhancement New feature or request
Milestone
Release 1.6.3

Comments

@lukehinds
Copy link
Member

lukehinds commented Mar 7, 2020 •
edited
Loading

We need to Deprecate Python 2, this issue can be for lodging possible impacts and discussing approaches we take.

I expect this will need to be a major release (2.x) as we will no longer have backwards compatibility to Python 2.
@lukehinds lukehinds added the enhancement New feature or request label Mar 7, 2020
@lukehinds lukehinds changed the title Depreciate Python 2 Deprecate Python 2 Mar 7, 2020
@lukehinds lukehinds self-assigned this Mar 7, 2020
@lukehinds
Copy link
Member Author

any thoughts @sigmavirus24 / @ericwb , do you agree we should go ahead or you see some reason to keep python 2 code?

@lukehinds lukehinds mentioned this issue Mar 7, 2020
Merged
@sigmavirus24
Copy link
Member

Let's kill it off. 🔥

@ericwb
Copy link
Member

ericwb commented Mar 7, 2020

Related to #500

@ericwb
Copy link
Member

ericwb commented Mar 7, 2020

Also, now that we use GitHub Actions for CI, we have till April 6th till we lose py27 Actions support.

https://github.blog/changelog/2020-02-27-github-actions-breaking-change-python-2-being-removed-from-all-virtual-environments/

@ericwb ericwb added this to the Release 1.6.3 milestone Mar 7, 2020
@ericwb
Copy link
Member

ericwb commented Mar 7, 2020

I suggest release 1.6.3 be the last of the Python 2.7. Then we version master to 2.x

@ericwb ericwb modified the milestones: Release 1.6.3, Release 2.0.0 Mar 7, 2020
@lukehinds
Copy link
Member Author

As we are going to do a major release to 2.0 are there any other non backwards compat changes we want to make, perhaps pep-518 or of that ilk?

lukehinds pushed a commit to lukehinds/bandit that referenced this issue Mar 30, 2020
Drop Python 2 Support
07393a8 
Python 2 is well beyond EOL now and will soon be removed from
github's workflows

This PR seeks to remove all calls / references and tests that
rely on Python 2.

* Remove six imports and six.Py2 conditionals
* Remove Py2 calls from github workflows
* Merged example files (e.g exec-py2.py|exec-py3.py > exec.py)
* Removed py2 env from setuptools
* Removed py2 env from tox

Resolves: PyCQA#584
@lukehinds lukehinds mentioned this issue Mar 30, 2020
Closed
@ericwb ericwb mentioned this issue May 18, 2020
Merged
ericwb added a commit that referenced this issue May 18, 2020
@ericwb
Drop Python2 build, test, and install
b78c938 
This commit drops building of Python 2.7 in our build matrix. It
also changes the testing of pylint and pep8 from 2.7 to 3.5. And
no longer should the binary be installable on Py2.7 via the change
to setup.py.

Partially-Fixes: #584

Signed-off-by: Eric Brown <browne@vmware.com>
@ericwb ericwb modified the milestones: Release 2.0.0, Release 1.6.3 Dec 6, 2020
@ericwb ericwb mentioned this issue Dec 18, 2020
Merged
ericwb added a commit that referenced this issue Dec 19, 2020
@ericwb
More complete removal of Python2 code (#674)
c9aa204 
* Removes six imports and six.Py2 conditionals
* Merged example files (e.g exec-py2.py|exec-py3.py > exec.py)
* Removes unnecessary workarounds for Py2 bugs

Fixes #584

Signed-off-by: Eric Brown <browne@vmware.com>
mikespallino pushed a commit to mikespallino/bandit that referenced this issue Aug 25, 2021
@ericwb @mikespallino
Drop Python2 build, test, and install
147ca24 
This commit drops building of Python 2.7 in our build matrix. It
also changes the testing of pylint and pep8 from 2.7 to 3.5. And
no longer should the binary be installable on Py2.7 via the change
to setup.py.

Partially-Fixes: PyCQA#584

Signed-off-by: Eric Brown <browne@vmware.com>
mikespallino pushed a commit to mikespallino/bandit that referenced this issue Aug 25, 2021
@ericwb @mikespallino
More complete removal of Python2 code (PyCQA#674)
b9bbc31 
* Removes six imports and six.Py2 conditionals
* Merged example files (e.g exec-py2.py|exec-py3.py > exec.py)
* Removes unnecessary workarounds for Py2 bugs

Fixes PyCQA#584

Signed-off-by: Eric Brown <browne@vmware.com>
mikespallino pushed a commit to mikespallino/bandit that referenced this issue Jan 7, 2022
@ericwb @mikespallino
Drop Python2 build, test, and install
ceb5fa2 
This commit drops building of Python 2.7 in our build matrix. It
also changes the testing of pylint and pep8 from 2.7 to 3.5. And
no longer should the binary be installable on Py2.7 via the change
to setup.py.

Partially-Fixes: PyCQA#584

Signed-off-by: Eric Brown <browne@vmware.com>
mikespallino pushed a commit to mikespallino/bandit that referenced this issue Jan 7, 2022
@ericwb @mikespallino
More complete removal of Python2 code (PyCQA#674)
fb92550 
* Removes six imports and six.Py2 conditionals
* Merged example files (e.g exec-py2.py|exec-py3.py > exec.py)
* Removes unnecessary workarounds for Py2 bugs

Fixes PyCQA#584

Signed-off-by: Eric Brown <browne@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukehinds lukehinds

Labels
enhancement New feature or request
Projects
None yet
Milestone
Release 1.6.3
3 participants
@sigmavirus24 @ericwb @lukehinds