Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

language and linting updates #1015

Merged
merged 3 commits into from
Apr 6, 2023
Merged

language and linting updates #1015

merged 3 commits into from
Apr 6, 2023

Conversation

marksmayo
Copy link
Contributor

  • converted several format strings to f-strings
  • sorted and tidied imports (isort)
  • cleaned some whitespace
  • updated pylintrc to exclude examples
  • updated pylintrc to specify all currently failing cases, so any new ones could be part of pre-commit if so wished

@marksmayo
language and linting updates
25af937 
 - converted several format strings to f-strings
 - sorted and tidied imports (isort)
 - cleaned some whitespace
 - updated pylintrc to exclude examples
 - updated pylintrc to specify all currently failing cases, so any new ones could be part of pre-commit if so wished
ericwb
ericwb requested changes Apr 4, 2023
View reviewed changes
bandit/core/config.py Outdated Show resolved Hide resolved
pylintrc Show resolved Hide resolved
@marksmayo
Update config.py
26d29be 
match pep8 for imports
@marksmayo marksmayo requested a review from ericwb April 4, 2023 04:53
ericwb
ericwb reviewed Apr 6, 2023
View reviewed changes
Copy link
Member

@ericwb ericwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit suggestion, otherwise I think it's ready.

pylintrc Outdated Show resolved Hide resolved
@marksmayo
Update pylintrc
4cf946f 
stylistic
@marksmayo marksmayo requested a review from ericwb April 6, 2023 03:31
ericwb
ericwb approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@ericwb ericwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericwb ericwb merged commit 36fc7be into PyCQA:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericwb ericwb ericwb approved these changes

@lukehinds lukehinds Awaiting requested review from lukehinds lukehinds is a code owner

@sigmavirus24 sigmavirus24 Awaiting requested review from sigmavirus24 sigmavirus24 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marksmayo @ericwb