Performance fix #502
Merged
Performance fix #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lines were introduced in 7c4b9fa and have two effects. First they cause `get_issue_list` to run twice and before the user receives feedback that bandit started running. Secondly it does not display any output if no issues are found, which is an unintended behavior change.
ericwb
requested changes
Jun 4, 2019
There was a problem hiding this comment.
Also need a change to the screen formatter here: https://github.com/PyCQA/bandit/blob/master/bandit/formatters/screen.py#L176
|
Hi @tylerwince, can you please also make a change to screen.py |
|
@ericwb done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #490 and replace PR #491