Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random.Random to B311 checks #940

Merged
merged 2 commits into from
May 22, 2023
Merged

Add random.Random to B311 checks #940

merged 2 commits into from
May 22, 2023

Conversation

shiftinv
Copy link
Contributor

The lowercase random.random already matches random.Random on Windows as well
(due to being case-insensitive), but not on other platforms.

Resolves #926.

The lowercase `random.random` already matches `random.Random` on Windows as well
(due to being case-insensitive), but not on other platforms.

Resolves: PyCQA#926
@daavoo
Copy link

daavoo commented May 22, 2023

Hi! Friendly ping.
What's the status of this?

The inconsistency across platforms is inconvenient when running automated checks against multiple platforms.

Copy link
Member

@ericwb ericwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericwb ericwb merged commit 4182f6b into PyCQA:main May 22, 2023
skshetry added a commit to iterative/dvc that referenced this pull request Jul 3, 2023
See PyCQA/bandit#940.

Will not be needed when new version of bandit comes.
skshetry added a commit to iterative/dvc that referenced this pull request Jul 3, 2023
See PyCQA/bandit#940.

Will not be needed when new version of bandit comes.
charliermarsh pushed a commit to astral-sh/ruff that referenced this pull request Mar 11, 2024
…S605` (#10313)

## Summary

Pick up updates made in latest
[releases](https://github.com/PyCQA/bandit/releases) of `bandit`:
- `S311`: PyCQA/bandit#940 and
PyCQA/bandit#1096
- `S324`: PyCQA/bandit#1018
- `S605`: PyCQA/bandit#1116

## Test Plan

Snapshot tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency of random.Random detection between different platforms
3 participants