Add b024: abstract class with no abstract methods #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakkdl
force-pushed
the
abstract_class_no_abstract_methods
branch
from
e09ad12
to
8e751a7
Compare
|
Couple possibilities on how liberal the name checks should be to balance false/missed alarms. You can check |
|
I'd warn only if the name is exactly |
jakkdl
force-pushed
the
abstract_class_no_abstract_methods
branch
2 times, most recently
from
0e28577
to
c307f23
Compare
|
I was thinking more if any other libraries implement (Previous CI run failed due to me forgetting to update lines after black formatted the test file) |
jakkdl
force-pushed
the
abstract_class_no_abstract_methods
branch
2 times, most recently
from
4100a78
to
4036ee1
Compare
|
Hmm - Where be the CI? I clicked approve :| |
|
Stuck in queued, and there's an incident https://www.githubstatus.com/incidents/8gpymn7rystj Should be fine in a few hours? |
Zac-HD
approved these changes
Aug 18, 2022
Closed
jiang1997
added a commit
to jiang1997/skywalking-python
that referenced
this pull request
Aug 28, 2022
More details about B024 here PyCQA/flake8-bugbear#274 * ./skywalking/agent/protocol/__init__.py:22:1: B024 Protocol is an abstract base class, but it has no abstract methods. Set 'heartbeat', 'report' and 'report_log' as abstract method * ./skywalking/trace/span.py:36:1: B024 Span is an abstract base class, but it has no abstract methods. Prevent base class Span from being directly instantiated by raising error in __new__ with reference to https://stackoverflow.com/questions/7989042/preventing-a-class-from-direct-instantiation-in-python * ./tests/plugin/base.py:35:1: B024 TestPluginBase is an abstract base class Due to pytest may instantiate parent class for searching test functions, TestPluginBase has to be instantiable.
jiang1997
added a commit
to jiang1997/skywalking-python
that referenced
this pull request
Aug 28, 2022
More details about B024 here PyCQA/flake8-bugbear#274 * ./skywalking/agent/protocol/__init__.py:22:1: B024 Protocol is an abstract base class, but it has no abstract methods. Set 'heartbeat', 'report' and 'report_log' as abstract method * ./skywalking/trace/span.py:36:1: B024 Span is an abstract base class, but it has no abstract methods. Prevent base class Span from being directly instantiated by raising error in __new__ with reference to https://stackoverflow.com/questions/7989042/preventing-a-class-from-direct-instantiation-in-python * ./tests/plugin/base.py:35:1: B024 TestPluginBase is an abstract base class Due to pytest may instantiate parent class for searching test functions, TestPluginBase has to be instantiable.
jiang1997
added a commit
to jiang1997/skywalking-python
that referenced
this pull request
Aug 28, 2022
More details about B024 here PyCQA/flake8-bugbear#274 * ./skywalking/agent/protocol/__init__.py:22:1: B024 Protocol is an abstract base class, but it has no abstract methods. Set 'heartbeat', 'report' and 'report_log' as abstract method * ./skywalking/trace/span.py:36:1: B024 Span is an abstract base class, but it has no abstract methods. Prevent base class Span from being directly instantiated by raising error in __new__ with reference to https://stackoverflow.com/questions/7989042/preventing-a-class-from-direct-instantiation-in-python * ./tests/plugin/base.py:35:1: B024 TestPluginBase is an abstract base class Due to pytest may instantiate parent class for searching test functions, TestPluginBase has to be instantiable.
jiang1997
added a commit
to jiang1997/skywalking-python
that referenced
this pull request
Aug 30, 2022
More details about B024 here PyCQA/flake8-bugbear#274 * ./skywalking/agent/protocol/__init__.py:22:1: B024 Protocol is an abstract base class, but it has no abstract methods. Set 'heartbeat', 'report' and 'report_log' as abstract method * ./skywalking/trace/span.py:36:1: B024 Span is an abstract base class, but it has no abstract methods. Prevent base class Span from being directly instantiated by raising error in __new__ with reference to https://stackoverflow.com/questions/7989042/preventing-a-class-from-direct-instantiation-in-python * ./tests/plugin/base.py:35:1: B024 TestPluginBase is an abstract base class Due to pytest may instantiate parent class for searching test functions, TestPluginBase has to be instantiable.
jiang1997
added a commit
to jiang1997/skywalking-python
that referenced
this pull request
Aug 30, 2022
More details about B024 here PyCQA/flake8-bugbear#274 * ./skywalking/agent/protocol/__init__.py:22:1: B024 Protocol is an abstract base class, but it has no abstract methods. Set 'heartbeat', 'report' and 'report_log' as abstract method * ./skywalking/trace/span.py:36:1: B024 Span is an abstract base class, but it has no abstract methods. Prevent base class Span from being directly instantiated by raising error in __new__ with reference to https://stackoverflow.com/questions/7989042/preventing-a-class-from-direct-instantiation-in-python * ./tests/plugin/base.py:35:1: B024 TestPluginBase is an abstract base class Due to pytest instantiating parent class, TestPluginBase has to be instantiable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First requested error in #273