-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate metadata from setup.py to setup.cfg #288
Conversation
Done using https://pypi.org/project/setuptools-py2cfg plus manual modifications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks ...
Just one question; why not move to pyproject.toml
?
- I'm happy to take this step than pyproject.toml but just wondering why
- I believe setuptools support enough of the PEP now for pyproject.toml for pure python projects like us - I could be wrong tho
[metadata] | ||
license_file = LICENSE | ||
name = flake8-bugbear | ||
version = attr: bugbear.__version__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL - This will help releases. Thanks.
Because flake8 does not support py project.toml. PyCQA/flake8#234 |
Good enough reason for now. Thanks for this. Lets roll from here and move to |
@cooperlees @cclauss FYI, there is a plugin that allows |
My sense is that a separate, supported text file is safer in the near-term and long-term than adding another dependency. In fact, there are numerous outside dependencies that attempt to paper over this situation:
But none of these are from PyCQA and I believe that the best approach would be for the PyCQA to solve this problem internally rather than encouraging the community to paper over it by adding external dependencies. |
Totally agree with PyCQA solving this and making it first class. Lets follow + comment on PyCQA/flake8#234 |
This pull request was created using https://pypi.org/project/setuptools-py2cfg plus manual modifications.
https://setuptools.pypa.io/en/latest/userguide/quickstart.html#basic-use