Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace travis and tox with github actions #52

Merged
merged 19 commits into from
Jan 14, 2022
Merged

Conversation

Akuli
Copy link
Collaborator

@Akuli Akuli commented Jan 14, 2022

I found tox quite confusing. It outputs a long wall of text when I run tox. I'd much rather have one local development environment, and have github actions try several different environments for me. If someone wants to keep tox, let me know and I'll try to preserve it.

pyi.py Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
@Akuli Akuli marked this pull request as ready for review January 14, 2022 11:21
@Akuli Akuli mentioned this pull request Jan 14, 2022
@srittau
Copy link
Collaborator

srittau commented Jan 14, 2022

I'm not using tox myself, so I'm +0 on removing it. And obviously +1 on dropping Travis CI (which doesn't work anymore) in favor of GitHub Actions. But currently this PR does a bit too much for me, since I'd like to keep a clean git history. Could we split at least the following?

  • Fixing pyi.py and the tests, setup.py fixes
  • Replacing Travis CI and tox with GitHub Actions

@Akuli
Copy link
Collaborator Author

Akuli commented Jan 14, 2022

Unrelated things should be gone now.

@JelleZijlstra
Copy link
Collaborator

Thank you!

@JelleZijlstra JelleZijlstra merged commit e8698ff into master Jan 14, 2022
@JelleZijlstra JelleZijlstra deleted the github-actions branch January 14, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants