-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further README improvements #72
Conversation
- Move the verbiage about fragility to the CONTRIBUTING document as it's not relevant to users - Mention that we also provide pyi-specific checks - Use double quotes for code strings
I think this should complete #68. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, otherwise looks great to me.
I wonder if the "authors" section could also be updated? You and Łukasz obviously deserve special credit, having put far more effort into the package than anybody else — but at the moment, I think it gives the impression that you and Łukasz are the sole maintainers 🙂
Perhaps "created by Łukasz and Jelle, and now maintained by [list of maintainers]"?
CONTRIBUTING.rst
Outdated
@@ -36,3 +36,15 @@ Look in ``.github/workflows/`` to find the commands. | |||
For example, to run tests:: | |||
|
|||
$ python3 -m pytest | |||
|
|||
Possible future changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is really nice, but I think I'd call it "Roadmap for development", or something similar, and then just have a bullet-point list introduced with "here are some of the changes we'd like to see happen"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like a bullet-point list with more specifics would just duplicate the issue tracker though. I want to avoid adding something that inevitably gets out of date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, then let's just create issues for these two items, and use this section to point people towards the issue tracker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I think these two don't really merit issues. The first is a declaration of policy, and we already have issues for the various specific cases. The second is more of a future risk that doesn't necessarily produce an actionable issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the second doesn't translate to an actionable issue, then I don't really think it belongs in README or CONTRIBUTING -- maybe we should just delete it?
Yes, we should update the authors section, but I'd like to keep that separate because it requires confirmation from each maintainer about how they'd like to be credited. I don't think I need special credit; Łukasz set up the framework and I just added a few specific checks. |
Sure. |
How about we keep the stuff about incompatibility with other plugins in the README, but rephrase it so that it sounds less like a TODO for maintainers and more of a warning for users? |
That would be awesome :) |
Thanks for the reviews! I now dropped the note about future changes since it doesn't really add much over the issue tracker, and also dropped the note about the brittleness of the forward references stuff because it hasn't been an issue in the years since this package was created. Instead I added a note about compatibility with other plugins that produce inappropriate errors on pyi files, which has been a real issue. |
Co-authored-by: Akuli <akuviljanen17@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
as it's not relevant to users