Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure_newline_before_comments shouldn't rely on the default lines between sections config #1389

Closed
sztamas opened this issue Aug 18, 2020 · 0 comments · Fixed by #1390
Closed

ensure_newline_before_comments shouldn't rely on the default lines between sections config #1389

sztamas opened this issue Aug 18, 2020 · 0 comments · Fixed by #1390

Comments

@sztamas
Copy link
Collaborator

sztamas commented Aug 18, 2020

The current implementation of ensure_newline_before_comments works only inside a section.

This bug goes undetected with the default configuration of 1 for lines_between_sections, but no empty line is inserted before a comment if lines_between_sections is changed to 0.
sztamas added a commit to sztamas/isort that referenced this issue Aug 18, 2020
@sztamas
Demonstrates problem with PyCQA#1389.
6bc66fb 
Changes existing test's configuration so it has no lines between
sections.
The default of 1 masks the error.
sztamas added a commit to sztamas/isort that referenced this issue Aug 18, 2020
@sztamas
Fixes PyCQA#1389
681fdd3
@sztamas sztamas mentioned this issue Aug 18, 2020
Merged
timothycrosley added a commit that referenced this issue Aug 22, 2020
@timothycrosley
Update changelog to mention #1389 fix
ce52dca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue/1389/ensure new line before comments bug sztamas/isort
1 participant
@sztamas