Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goal Zero: Full testing of stdin CLI Options #1472

Closed
timothycrosley opened this issue Sep 10, 2020 · 3 comments
Closed

Goal Zero: Full testing of stdin CLI Options #1472

timothycrosley opened this issue Sep 10, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@timothycrosley
Copy link
Member

This ticket is part of an aspirational goal for the isort project to achieve zero regressions through the remaining life of the 5.0.0 release, without slowing down the release velocity.

Currently, as mentioned by @karrtikr there have been an unfortunate number of regressions in the 5.x series involving the usage of streaming from stdin. This ticket represents the work to expand the automated test suite to ensure every CLI flag is tested against this mode of usage to avoid further regressions.

@anirudnits
Copy link
Collaborator

anirudnits commented Sep 14, 2020

@timothycrosley if this is not very urgent, I can work on this and maybe get around by this weekend(?) Obviously that's if nobody is yet to actual start working on this.

@timothycrosley
Copy link
Member Author

@anirudnits that would be very appreciated! No urgency on this ticket.

@timothycrosley
Copy link
Member Author

Closing as @anirudnits added a very comprehensive set of tests to the project,

Thanks!

~Timothy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants