isort 5.5.2 mangles lines that happens to start with from

[wadetregaskis-linkedin]

e.g.:

    raise SomeException("Blah") \
        from exceptionsInfo.popitem()[1]

It transforms it into the gibberish:

    raise SomeException("Blah") \
        from exceptionsInfo.popitem import [1]

isort 4.x didn't do this.

[timothycrosley]

@wadetregaskis-linkedin that's a nasty bug! I'll make sure the isort project has a release soon that resolves it and adds additional test cases to ensure it never happens again.

@anirudnits I'm a bit confused about your example? One of the biggest headline features of isort 5 is its ability to sort imports anywhere they are within a file, largely safely: https://pycqa.github.io/isort/docs/major_releases/introducing_isort_5/#sort-imports-anywhere if isort is simply sorting the second import statement that's good! If you encountered any sort of incorrect syntax produced, that of course would be a major bug like the one @wadetregaskis-linkedin raised

Thanks!

~Timothy

[timothycrosley]

For anyone that runs into this before it is resolved, one option would be to utilize action comments to skip the offending section, since these should be very rare: https://pycqa.github.io/isort/docs/configuration/action_comments/

[anirudnits]

@timothycrosley sorry my bad :(

[timothycrosley]

@anirudnits No worries! Just wanted to make sure there wasn't an additional error case of this proportion

[timothycrosley]

A 5.5.3 hot fix release has just been completed to PyPI that fixes this issue. Confirmed that Python's grammar only allows from to be used for imports, within raise statements, and within yield statements (yield from). Considerable additional testing has been placed around these usages to make sure isort does not mistake them on line continuations as import statements.

Thanks!

~Timothy