Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import statement with \ right after import will get removed on sort #425

Closed
junzh0u opened this issue Apr 15, 2016 · 1 comment
Closed

import statement with \ right after import will get removed on sort #425

junzh0u opened this issue Apr 15, 2016 · 1 comment
Labels
bug Something isn't working

Comments

@junzh0u
Copy link

junzh0u commented Apr 15, 2016

Let's say I have a peice of code like this:

#!/usr/bin/python

from os import\
        getuid

print getuid()

After isort, it will become:

#!/usr/bin/python


print getuid()
bootandy added a commit to bootandy/isort that referenced this issue Apr 16, 2016
@bootandy
Fix hanging imports being removed
2afd9ea 
As mentioned in PyCQA#425
This fixes hanging imports being removed by isort.

Code was missing a whitespace when glueing the import line together
@bootandy bootandy mentioned this issue Apr 16, 2016
Merged
timothycrosley added a commit that referenced this issue Apr 21, 2016
@timothycrosley
Update changelog to include fix for issue #425
789a70a
@timothycrosley
Copy link
Member

@junzh0u, Thanks for reporting!

A fix has been prepared by @bootandy and will be included in the next point release (4.2.6)

Thanks!

~Timothy

@timothycrosley timothycrosley added the bug Something isn't working label Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@junzh0u @timothycrosley