Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting behaviour seemingly not stable across Python runtimes. #952

Closed
amcgregor opened this issue May 29, 2019 · 2 comments
Closed

Sorting behaviour seemingly not stable across Python runtimes. #952

amcgregor opened this issue May 29, 2019 · 2 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@amcgregor
Copy link

As can be seen in this Travis-CI test run the isort checks are failing only under Pypy runtimes, despite known_first_party being declared. What have I missed or am doing wrong?
@amcgregor amcgregor mentioned this issue May 29, 2019
Merged
@cs01
Copy link

cs01 commented Aug 28, 2019 •
edited
Loading

We are running into this as well the Travis build for wntrblm/nox#242, even after pinning the isort version. We had to turn off the call to isort in our Travis CI test. It's too bad because isort's functionality is really useful, IMO on par with black.

@timothycrosley timothycrosley mentioned this issue Feb 17, 2020
Closed
@timothycrosley
Copy link
Member

This should be fixed for the 5.0.0 release in spirit via this ticket: #1147

@timothycrosley timothycrosley added duplicate This issue or pull request already exists enhancement New feature or request labels Feb 17, 2020
@musoke musoke mentioned this issue Mar 9, 2020
Closed
musoke added a commit to auckland-cosmo/LearnAsYouGoEmulator that referenced this issue Mar 9, 2020
@musoke
ci(github): Run pre-commit in github actions
16cfe3b 
- Configure github actions to run pre-commit on the repo to check
style, etc.
- Update to stable/new versions of hooks to avoid spurious failures from
upstream updates.
- Flag a few imports in tests and examples with NOQA.  This is to avoid
bugs in isort.  In particular, isort is environment dependent.

    PyCQA/isort#1147
    PyCQA/isort#952
    PyCQA/isort#1007

- Disable one flake8 lint: 501, line too long
musoke added a commit to auckland-cosmo/LearnAsYouGoEmulator that referenced this issue Mar 9, 2020
@musoke
ci(github): Run pre-commit in github actions
9021ef4 
- Configure github actions to run pre-commit on the repo to check
style, etc.

- Update to stable/new versions of hooks to avoid spurious failures from
upstream updates.

- Flag a few imports in tests and examples with NOQA.  This is to avoid
bugs in isort.  In particular, isort is environment dependent.

    PyCQA/isort#1147
    PyCQA/isort#952
    PyCQA/isort#1007

- Disable one flake8 lint: 501, line too long
musoke added a commit to auckland-cosmo/LearnAsYouGoEmulator that referenced this issue Mar 9, 2020
@musoke
ci(github): Run pre-commit in github actions (#2)
608d8a4 
- Configure github actions to run pre-commit on the repo to check
style, etc.

- Update to stable/new versions of hooks to avoid spurious failures from
upstream updates.

- Flag a few imports in tests and examples with NOQA.  This is to avoid
bugs in isort.  In particular, isort is environment dependent.

    PyCQA/isort#1147
    PyCQA/isort#952
    PyCQA/isort#1007

- Disable one flake8 lint: 501, line too long
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amcgregor @timothycrosley @cs01