-
-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds color to ERROR and SUCCESS in check mode. #1349
Adds color to ERROR and SUCCESS in check mode. #1349
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1349 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 34 34
Lines 2288 2315 +27
=========================================
+ Hits 2288 2315 +27 |
This looks great! Unfortunately, this is complicated a bit by isorts policy to never include dependencies. isort is depended on by some large projects such as pylint, so in the past when it did include or rely on dependencies the odds of conflicts were very high. See: https://timothycrosley.github.io/isort/docs/major_releases/release_policy/#packaging-guarantees. I do think that the policy could be clarified to say that will change isort file output. However, it would still be necessary I believe to make this the non default, and require a flag such as |
OK, thanks for sharing the background info! How about adding We can keep the existing functionality as is, add a new What do you think? |
@sztamas Exactly! That sounds like a perfect solution |
This looks awesome! Thank you! |
Fixes #1177.
Did this with
colorama
as I think it doesn't warrant introducing something liketermcolor
orblessings
.colorama
is needed anyways with both of those to support Windows.Some further considerations:
--no-color
option to turned the colors explicitly off. Colorama turns them off by default if you're piping the results into another command--diff
Sidenote for @timothycrosley : we're running out of issues marked with
help_wanted
, so you might want to add a few more if you have the time 😄